On 18/02/16 17:20, Cedric BAIL wrote: > On Feb 18, 2016 02:07, "Tom Hacohen" <t...@osg.samsung.com> wrote: >> >> OK, this has to stop! >> >> If you revert someone's patch, LET HIM KNOW! Better if publicly on the >> ML and before you, but at the very least in private and after (or any >> other mix). He would have fixed it immediately. > > This break all tests and it was already past midnight in Europe when I > noticed it. I preferred to get make check back on track than have it turned > off for another day. Sorry, but tests is one if the only thing I will > restore with a revert. If this happen again, I would do it again.
He was probably awake, the point is not the revert, the point is the lack of communication. Ping him, see what's up, maybe he can fix it. > >> He wasn't even aware of the revert. The way you did it, this revert may >> have gone unnoticed forever. > > Next time I will also send a email answering to the commit that broke > things, but I would have expect him to read our git commit message on efl. I don't know if he does or doesn't. I'm the one who pointed this out to him, he missed it. It's easy to miss commits. Thanks, please send emails. -- Tom. > > Cedric > >> -- >> Tom. >> >> >> On 18/02/16 00:55, Cedric BAIL wrote: >>> cedric pushed a commit to branch master. >>> >>> > http://git.enlightenment.org/core/efl.git/commit/?id=56a21ab5f22a4bddcefd4ea7bd00582ba74c651d >>> >>> commit 56a21ab5f22a4bddcefd4ea7bd00582ba74c651d >>> Author: Cedric BAIL <ced...@osg.samsung.com> >>> Date: Wed Feb 17 14:34:20 2016 -0800 >>> >>> Revert "eolian: strict validation for EFL (errors by default)" >>> >>> This reverts commit 21a2a8007dc53e11842526191abab9f393b3d777 >>> >>> Please run make check from time to time. >>> --- >>> src/Makefile_Eolian_Helper.am | 8 ++++---- >>> src/lib/eolian/database_validate.c | 12 ++++++------ >>> 2 files changed, 10 insertions(+), 10 deletions(-) >>> >>> diff --git a/src/Makefile_Eolian_Helper.am > b/src/Makefile_Eolian_Helper.am >>> index 9159cf8..22b09d6 100644 >>> --- a/src/Makefile_Eolian_Helper.am >>> +++ b/src/Makefile_Eolian_Helper.am >>> @@ -15,21 +15,21 @@ SUFFIXES = .eo .eo.c .eo.h .eo.legacy.h .eot .eot.h >>> %.eo.c: %.eo ${_EOLIAN_GEN_DEP} >>> $(AM_V_EOL) \ >>> $(MKDIR_P) $(dir $@); \ >>> - EOLIAN_VALIDATE_STRICT=1 $(EOLIAN_GEN) --legacy $(EOLIAN_FLAGS) > --gc -o $@ $< >>> + $(EOLIAN_GEN) --legacy --silent-types $(EOLIAN_FLAGS) --gc -o $@ > $< >>> >>> %.eo.h: %.eo ${_EOLIAN_GEN_DEP} >>> $(AM_V_EOL) \ >>> $(MKDIR_P) $(dir $@); \ >>> - EOLIAN_VALIDATE_STRICT=1 $(EOLIAN_GEN) $(EOLIAN_FLAGS) --gh -o $@ > $< >>> + EOLIAN_VERBOSE_TYPES=1 $(EOLIAN_GEN) $(EOLIAN_FLAGS) --gh -o $@ $< >>> >>> %.eot.h: %.eot ${_EOLIAN_GEN_DEP} >>> $(AM_V_EOL) \ >>> $(MKDIR_P) $(dir $@); \ >>> - EOLIAN_VALIDATE_STRICT=1 $(EOLIAN_GEN) $(EOLIAN_FLAGS) --gh -o $@ > $< >>> + EOLIAN_VERBOSE_TYPES=1 $(EOLIAN_GEN) $(EOLIAN_FLAGS) --gh -o $@ $< >>> >>> %.eo.legacy.h: %.eo ${_EOLIAN_GEN_DEP} >>> $(AM_V_EOL) \ >>> $(MKDIR_P) $(dir $@); \ >>> - EOLIAN_VALIDATE_STRICT=1 $(EOLIAN_GEN) --legacy $(EOLIAN_FLAGS) > --gh -o $@ $< >>> + $(EOLIAN_GEN) --legacy --silent-types $(EOLIAN_FLAGS) --gh -o $@ > $< >>> >>> CLEANFILES += $(BUILT_SOURCES) >>> diff --git a/src/lib/eolian/database_validate.c > b/src/lib/eolian/database_validate.c >>> index 2a44a3d..381564d 100644 >>> --- a/src/lib/eolian/database_validate.c >>> +++ b/src/lib/eolian/database_validate.c >>> @@ -174,10 +174,9 @@ _ef_map_cb(const Eina_Hash *hash EINA_UNUSED, > const void *key EINA_UNUSED, >>> static Eina_Bool >>> _type_error(const Validator *vs, const Eolian_Type *tp, const char > *msg) >>> { >>> - Eina_Bool weak = !getenv("EOLIAN_VALIDATE_STRICT"); >>> if (vs->silent_types) >>> - return weak; >>> - if (!weak) >>> + return EINA_FALSE; >>> + if (getenv("EOLIAN_VERBOSE_TYPES")) >>> { >>> fprintf(stderr, "eolian:%s:%d:%d: %s\n", tp->base.file, > tp->base.line, >>> tp->base.column, msg); >>> @@ -185,7 +184,7 @@ _type_error(const Validator *vs, const Eolian_Type > *tp, const char *msg) >>> } >>> eina_log_print(_eolian_log_dom, EINA_LOG_LEVEL_WARN, > tp->base.file, "", >>> tp->base.line, "%s at column %d", msg, > tp->base.column); >>> - return EINA_TRUE; >>> + return EINA_FALSE; >>> } >>> >>> static Eina_Bool >>> @@ -213,7 +212,8 @@ _validate_type(const Validator *vs, const > Eolian_Type *tp) >>> { >>> char buf[256]; >>> snprintf(buf, sizeof(buf), "undefined type %s", > tp->full_name); >>> - return _type_error(vs, tp, buf); >>> + _type_error(vs, tp, buf); >>> + return EINA_TRUE; /* for now only warn */ >>> } >>> return _validate_type(vs, tpp); >>> } >>> @@ -246,7 +246,7 @@ _validate_type(const Validator *vs, const > Eolian_Type *tp) >>> char buf[256]; >>> snprintf(buf, sizeof(buf), "undefined class %s " >>> "(likely wrong namespacing)", tp->full_name); >>> - return _type_error(vs, tp, buf); >>> + _type_error(vs, tp, buf); >>> } >>> return EINA_TRUE; >>> } >>> >> >> >> > ------------------------------------------------------------------------------ >> Site24x7 APM Insight: Get Deep Visibility into Application Performance >> APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month >> Monitor end-to-end web transactions and take corrective actions now >> Troubleshoot faster and improve end-user experience. Signup Now! >> http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 >> _______________________________________________ >> enlightenment-devel mailing list >> enlightenment-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >> > ------------------------------------------------------------------------------ > Site24x7 APM Insight: Get Deep Visibility into Application Performance > APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month > Monitor end-to-end web transactions and take corrective actions now > Troubleshoot faster and improve end-user experience. Signup Now! > http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
