On 18/02/16 19:32, Mike Blumenkrantz wrote: > I appreciate it, thanks. > > For things like this which affect a lot of components (eg. eolian > validation), I think the method for enabling them should be to first go > through and fix all the issues first so that it starts with a clean state, > then enable enforcing after to keep it that way. Thoughts?
I you're still chewing on this topic. This is not eolian validation, so no idea why you chose it as an example when replying to this commit, especially since the eolian validation changes went through well with the only issue being small failures with eolian\cpp. First go an fix all the issues: exactly what happened in the eolian validation case. As for this one, as I said in the other thread, I only discovered the implications in retrospect, I didn't think that was the case, so this is irrelevant here. I disagree about first fixing all the issues found before enabling extra safety tests. We tried this with eolian validation (warnings), and no one pitched in except for a few patches by Vitor. If it's not in your face, it's not gonna get fixed. Sure, you don't want to flood people with issues (which is why I started the other thread in the first place) either, so you need to get many fixed before you enable it globally. It's almost the same as you don't expect Stefan to fix all coverity issues just because he's running the coverity tests. -- Tom. > > On Thu, Feb 18, 2016 at 2:29 PM Tom Hacohen <t...@stosb.com> wrote: > >> tasn pushed a commit to branch master. >> >> >> http://git.enlightenment.org/core/efl.git/commit/?id=1f576da49e662a563d16ea4915e485516aa2b4ee >> >> commit 1f576da49e662a563d16ea4915e485516aa2b4ee >> Author: Tom Hacohen <t...@stosb.com> >> Date: Thu Feb 18 19:28:41 2016 +0000 >> >> Revert "Eo: Print an ERR when deleting an object with data refs." >> >> Revert this in the meanwhile. See discussion on the ML. This should be >> enabled though, and issues fixed. >> >> This reverts commit ec2f92e35f5a0836933d82b6b7f518a1d7550afc. >> --- >> src/lib/eo/eo_private.h | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/src/lib/eo/eo_private.h b/src/lib/eo/eo_private.h >> index f3ec7db..869745c 100644 >> --- a/src/lib/eo/eo_private.h >> +++ b/src/lib/eo/eo_private.h >> @@ -245,11 +245,12 @@ _eo_free(_Eo_Object *obj) >> { >> _Eo_Class *klass = (_Eo_Class*) obj->klass; >> >> +#ifdef EO_DEBUG >> if (obj->datarefcount) >> { >> ERR("Object %p data still referenced %d time(s).", obj, >> obj->datarefcount); >> } >> - >> +#endif >> _eo_id_release((Eo_Id) _eo_id_get(obj)); >> >> eina_spinlock_take(&klass->objects.trash_lock); >> >> -- >> >> >> > ------------------------------------------------------------------------------ > Site24x7 APM Insight: Get Deep Visibility into Application Performance > APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month > Monitor end-to-end web transactions and take corrective actions now > Troubleshoot faster and improve end-user experience. Signup Now! > http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
