If I'm understanding the issue correctly (judging by his code changes and commit message) elm_scale properly applies to the children. The problem is that widgets that have scale set don't set the correct scale on the children if the children are added *after* the scale was set.
On 10/03/16 11:59, Hermet Park wrote: > that's the elm scale function. > > -----Original Message----- > From: "Tom Hacohen"<t...@osg.samsung.com> > To: <enlightenment-devel@lists.sourceforge.net>; > Cc: > Sent: 2016-03-10 (목) 20:14:34 > Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: Scaling test: > reorder instructions to set the correct scale > > It's not the elm scale function, it's elm widget that needs to propagate > scale when adding a child. Jack, you should update elm_widget instead of > hiding the bug. > > -- > Tom. > > On 10/03/16 10:57, Hermet Park wrote: >> Sounds like elm scale function is broken. :( >> >> -----Original Message----- >> From: "Daniel Zaoui"<daniel.za...@samsung.com> >> To: <g...@lists.enlightenment.org>; >> Cc: >> Sent: 2016-03-03 (목) 17:54:51 >> Subject: [EGIT] [core/elementary] master 01/01: Scaling test: reorder >> instructions to set the correct scale >> >> jackdanielz pushed a commit to branch master. >> >> http://git.enlightenment.org/core/elementary.git/commit/?id=36669f1eccc3b6c320fb4c4ecc0e029b95834f57 >> >> commit 36669f1eccc3b6c320fb4c4ecc0e029b95834f57 >> Author: Daniel Zaoui <daniel.za...@samsung.com> >> Date: Thu Mar 3 10:25:22 2016 +0200 >> >> Scaling test: reorder instructions to set the correct scale >> >> If the scale is set on an object before contents are set, it will not >> pass to them. Because of this, in the test, scale of the first label >> remains 1.0, i.e the window scale, instead of 0.5. >> The patch modifies the order of the instructions by setting the scale >> after setting the label as content of the frame. >> --- >> src/bin/test_scaling.c 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/bin/test_scaling.c b/src/bin/test_scaling.c >> index d0d0f3c..84b20c6 100644 >> --- a/src/bin/test_scaling.c >> +++ b/src/bin/test_scaling.c >> @@ -76,7 +76,6 @@ test_scaling2(void *data EINA_UNUSED, Evas_Object *obj >> EINA_UNUSED, void *event_ >> evas_object_show(bx); >> >> fr = elm_frame_add(win); >> - elm_object_scale_set(fr, 0.5); >> elm_object_text_set(fr, "Scale: 0.5"); >> lb = elm_label_add(win); >> elm_object_text_set(lb, >> @@ -84,6 +83,7 @@ test_scaling2(void *data EINA_UNUSED, Evas_Object *obj >> EINA_UNUSED, void *event_ >> "is 0.5. Child should<br/>" >> "inherit it."); >> elm_object_content_set(fr, lb); >> + elm_object_scale_set(fr, 0.5); >> evas_object_show(lb); >> elm_box_pack_end(bx, fr); >> evas_object_show(fr); >> > > > ------------------------------------------------------------------------------ > Transform Data into Opportunity. > Accelerate data analysis in your applications with > Intel Data Analytics Acceleration Library. > Click to learn more. > http://pubads.g.doubleclick.net/gampad/clk?id=278785111&iu=/4140 > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ > Transform Data into Opportunity. > Accelerate data analysis in your applications with > Intel Data Analytics Acceleration Library. > Click to learn more. > http://pubads.g.doubleclick.net/gampad/clk?id=278785111&iu=/4140 > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785111&iu=/4140 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
