On 15/03/16 09:49, Tom Hacohen wrote: > On 14/03/16 10:09, Tom Hacohen wrote: >> On 11/03/16 15:06, Tom Hacohen wrote: >>> Hey, >>> >>> As you may have noticed I reverted the patches regarding eo_add(). The >>> reason for that is that following complaints (why didn't you say >>> anything following my proposal and *before* I did all the work?!?!) I >>> came up with a better way to do it that will let us keep the current >>> syntax except for one thing, which is what this post is about. >>> >>> If you are interested in the implementation details of this solution, >>> feel free to ask on IRC or the other thread. >>> >>> Anyhow, as part of this solution, we need to define a macro that will be >>> used inside eo_add. At the moment it's called eoid (and not a macro >>> yet), so eo_add() looks like this: >>> obj = eo_add(CLASS, parent, efl_text_set(eoid, "test")); >>> >>> I'd like to change "eoid" to something that is: >>> 1. more meaningful. >>> 2. less likely to clash. >>> >>> I was thinking (and q66 likes it too) eo_self could work. >>> >>> So the above example will become: >>> obj = eo_add(CLASS, parent, efl_text_set(eo_self, "test")); >>> >>> Do you have any ideas for a better name for this? I rather like eo_self. >>> I just really don't want to change it again, so whatever we go with now >>> will be what we end up with. >>> >>> Please let me know if you have better alternatives. >> >> Just a reminder: if I don't hear any strong objections by tomorrow, I'll >> carry on with this plan. > > OK. Except for Felipe who didn't manage to convince anyone, I believe > there are no objections. > > I'm going to start working on it very soon. If you want to say anything, > you still have time.
Done. If you want, I have a script up that does the migration for you: https://devs.enlightenment.org/~tasn/migrate_eo_add.py You can run it how many times you want on the same source. It's smart enough to deal with that. This should be the last break hopefully. -- Tom. ------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140 _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel