Looks like a bad copy and paste from me. Thanks for the fix :) On 16 March 2016 at 22:41, Tom Hacohen <[email protected]> wrote:
> Fair enough. > > On 16/03/16 13:38, Christopher Michael wrote: > > Sure, that would have worked also. I just went with what was above in > > the "constructor" functions. > > > > Cheers, > > dh > > > > > > On 03/16/2016 09:27 AM, Tom Hacohen wrote: > >> Evas_Object_Protected_Data *obj = eo_data_scope_get(eo, > EVAS_OBJECT_CLASS); > >> > >> Would have been fine (and encouraged). The problem was the "obj = obj = > X". > >> > >> -- > >> Tom. > >> > >> On 16/03/16 13:25, Chris Michael wrote: > >>> devilhorns pushed a commit to branch master. > >>> > >>> > http://git.enlightenment.org/core/efl.git/commit/?id=114d010fc122a9cb1ca6a2d5f87691f13950903d > >>> > >>> commit 114d010fc122a9cb1ca6a2d5f87691f13950903d > >>> Author: Chris Michael <[email protected]> > >>> Date: Wed Mar 16 09:21:08 2016 -0400 > >>> > >>> evas: Fix incorrect expression in efl_canvas_surface_wayland > >>> > >>> This patch fixes an issue detected by Coverity where 'obj' is > written > >>> twice with the same value > >>> > >>> CID1353365 > >>> > >>> @fix > >>> > >>> Signed-off-by: Chris Michael <[email protected]> > >>> --- > >>> src/lib/evas/canvas/efl_canvas_surface_wayland.c | 4 +++- > >>> 1 file changed, 3 insertions(+), 1 deletion(-) > >>> > >>> diff --git a/src/lib/evas/canvas/efl_canvas_surface_wayland.c > b/src/lib/evas/canvas/efl_canvas_surface_wayland.c > >>> index 1798107..3b1b358 100644 > >>> --- a/src/lib/evas/canvas/efl_canvas_surface_wayland.c > >>> +++ b/src/lib/evas/canvas/efl_canvas_surface_wayland.c > >>> @@ -30,7 +30,9 @@ _efl_canvas_surface_wayland_eo_base_constructor(Eo > *eo, Efl_Canvas_Surface_Wayla > >>> EOLIAN static void > >>> _efl_canvas_surface_wayland_eo_base_destructor(Eo *eo, > Efl_Canvas_Surface_Wayland_Data *pd) > >>> { > >>> - Evas_Object_Protected_Data *obj = obj = eo_data_scope_get(eo, > EVAS_OBJECT_CLASS); > >>> + Evas_Object_Protected_Data *obj; > >>> + > >>> + obj = eo_data_scope_get(eo, EVAS_OBJECT_CLASS); > >>> > >>> ENFN->image_native_shutdown(ENDT, EVAS_NATIVE_SURFACE_WL); > >>> eo_data_unref(eo, pd->base); > >>> > >> > >> > >> > ------------------------------------------------------------------------------ > >> Transform Data into Opportunity. > >> Accelerate data analysis in your applications with > >> Intel Data Analytics Acceleration Library. > >> Click to learn more. > >> http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140 > >> _______________________________________________ > >> enlightenment-devel mailing list > >> [email protected] > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >> > > > > > > > ------------------------------------------------------------------------------ > > Transform Data into Opportunity. > > Accelerate data analysis in your applications with > > Intel Data Analytics Acceleration Library. > > Click to learn more. > > http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140 > > _______________________________________________ > > enlightenment-devel mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > ------------------------------------------------------------------------------ > Transform Data into Opportunity. > Accelerate data analysis in your applications with > Intel Data Analytics Acceleration Library. > Click to learn more. > http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140 > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > -- Jean-Philippe André ------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140 _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
