On Sat, 26 Mar 2016 09:05:46 -0400 Christopher Michael <[email protected]> said:
> On 03/25/2016 09:56 PM, Carsten Haitzler wrote: > > On Fri, 25 Mar 2016 08:59:59 -0400 Christopher Michael > > <[email protected]> said: > > > >> On 03/24/2016 09:56 PM, Carsten Haitzler wrote: > >>> raster pushed a commit to branch master. > >>> > >>> http://git.enlightenment.org/core/efl.git/commit/?id=453329916ee1bcaf5f9882cb90ed1ec8572a4695 > >>> > >>> commit 453329916ee1bcaf5f9882cb90ed1ec8572a4695 > >>> Author: Carsten Haitzler (Rasterman) <[email protected]> > >>> Date: Fri Mar 25 10:53:38 2016 +0900 > >>> > >>> efl: fix build when drm and fb are enabled .. and more > >>> > >>> after elm merge build broke with things like this enabled. this > >>> fixes that. > >>> > >>> i'd like to bring up one issue here. ecore_drm is not a good > >>> abstractionlayer. it requires libdrm and other headers from system > >>> and it should have abstracted things so the system libdrm is hidden/not > >>> needed for build (or even perhaps at runtime and this could be > >>> rolled into ecore_drm). this is how ecore_x is... and ecore_fb etc. > >> > >> No worries. I'll modify drm2 a bit and use dlsym (I suppose) rather than > >> using the drm headers/library > > > > oh you dont need to use dlsym - it's about the headers. the headers #include > > libdrm headers. you need a libdrm header set installed (and need to know > > where they are) to use ecore_drm - that make ecore_drm a "leaky > > abstraction". it'd be best if i can use ecore_drm and not need to also need > > to know about libdrm. ie i have to do > > > > pkg-config --cflags ecore_drm libdrm > > > > to get cflags that will build against ecore_drm ... where i really shouldnt > > need to do that - well i had to do that inside efl's configure.ac to fix the > > build effectively. :) i had to know i also had to find libdrm headers > > too. :) dlsym isn't needed. but fixing headers to not need libdrm headers > > too would be good. > > > > > > Ohhh, I see what you mean now. Ok, I don't think that will be terribly > difficult to fix. I'll address that when I return home. yeah. this is simple/easy and de-complicates compile-time dependencies. ALL you need is ecore_drm at compile time. but as it stands right now libdrm is a direct compile time requirement which is a little sad :( you're not much of an abstraction if this is the case. :) -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140 _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
