On 29/03/16 10:05, Daniel Zaoui wrote: > On Mon, 28 Mar 2016 07:03:39 -0700 > Cedric BAIL <[email protected]> wrote: > >> On Mar 27, 2016 22:49, "Daniel Zaoui" <[email protected]> >> wrote: >>> >>> On Mon, 28 Mar 2016 14:39:26 +0900 >>> Carsten Haitzler <[email protected]> (The Rasterman) wrote: >>> >>>> On Mon, 28 Mar 2016 07:21:21 +0300 Daniel Zaoui >>>> <[email protected]> said: >>>> >>>>> On Mon, 28 Mar 2016 08:58:22 +0900 >>>>> Carsten Haitzler <[email protected]> (The Rasterman) wrote: >>>>> >>>>>> On Sun, 27 Mar 2016 15:17:40 +0300 Daniel Zaoui >>>>>> <[email protected]> said: >>>>>> >>>>>>> Hi boyz, girlz, Raster, >>>>>>> >>>>>>> I have some issue with my today Exactness results. If you >>>>>>> look at the images, it seems there is some new aura around >>>>>>> some widgets. You won't see difference without the help of >>>>>>> Exactness. In the old Elementary, there are no differences. >>>>>>> In the merged one, the aura appears. >>>>>>> >>>>>>> So my question: which one is good? the original one or the >>>>>>> new one? Is it intended? Who is guilty? >>>>>> >>>>>> i changed the theme. i changed shadow images. :) you can see >>>>>> the difference. >>>>>> >>>>>> c413544ef74ba2ceee220e4e70b044758e4038c7 >>>>>> >>>>>> things generally look a lot nicer. :) aesthetic change. no >>>>>> bugs. :) >>>>> >>>>> Thanks for the info. >>>>> I will update the shots accordingly. >>>> >>>> these things will happen from time to time. it's kind of part of >>>> the theme - it's allows to change visually. it's just a >>>> bi-product of pixel-exact testing. while it's good to detect >>>> off-by-1 issues that may go missing often and only be found much >>>> later, it sucks with these changes. :) >>>> >>>> i might every now and again adjust theme a bit to look nicer. i >>>> have been toying with improvements on the side for a while the >>>> vast majority of which stays out of master .:) just thee shadow >>>> changes were so much nicer than the original i decided to push >>>> them over. :) >>>> >>>> >>> >>> No problem. With the merge, it made it harder to figure out if it >>> was a >> bug or an improvement. I am sure that for the next changes you will >> push, bisect will help us a lot for the decision to update the shots. >> >> Something we did talk with Stefan before was to setup the bot with an >> older theme. This would have 2 benefit I think. We will spot when we >> do break or theme compatibility more easily and you won't have this >> kind of problem anymore. We could go even further and record the >> theme file along with the tests and do the replay with it. This would >> make it possible to have multiple theme tests and allow people to >> provide test without having to care about this details (this is one >> if the reason I want to use eet in exactness, as it would just give >> one file to play a test that people can easily share). > > Well "won't have this kind of problem anymore" seems a little bit optimistic. > Anyway, to do that, we should wait for the widgets redesign that will for > sure change the theme. > > I am not so confident concerning packing the theme inside the rec file (not > just because it would make them huge). Having everyone using different themes > during recording would create a mess to understand where the problem is. It's > already a pain these days.
It's not about packing the theme file inside the .rec. That would be crazy. It's about putting a theme in the repo that is used by all the .rec files and basis for tests. It will solve all of these issues because theme changes will never happen any more. -- Tom. ------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785471&iu=/4140 _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
