On Thu, Apr 7, 2016 at 2:34 AM, Tom Hacohen <[email protected]> wrote: > On 07/04/16 09:39, Tom Hacohen wrote: >> Dude, we've been through this already and this is not what we talked about. >> >> You just made everything extremely ugly and annoying to use all around. >> Why did you *again* not let me have a look at it before pushing it?
There was no point delaying the review to a larger crowd for how macros and internals look like. They can obviously still be improved and will be until the release. Felipe should already be looking at your request. >> Wrapper macros (although they would have doubled everything) would have >> been much better here. Please add the compatible macros back. >> >> I expect to be talked to when changes are made to Eo API. Heck, even >> notified, I got neither. All development has been done in a public branch on enlightenment git. You should have seen activity on that branch for the past week every time you do a git pull rebase. We used the power of git and obviously it makes everything better ;-) On a more serious note, I absolutely disagree with the logic that we have gate keeper for part of our API. We are way to small of a community to start relying on one person for any component. We use git, we can fix and improve code as we go. We do use branch to get to a point where it is reviewable. clean enough, tested and usable to be landed. Once there, we should move to master where most people can actually see the change happening. Typically your comment on this commit are exactly on the point where I think further development should happen in master. They do not impact anyone using Eina_Promise API and are mostly internals improvements. And I do think they are good improvements to do. This also means that everyone can now look at Eina_Promise API and make comment. I will try to land small use of it next week in smaller patch so that people can see how to use it in their API and maybe some example also. >> Cedric: this goes to you too, as you've signed off this commit and >> pushed it. WTF. Yes, and I would still do it again. Landed commit are easy to review, tested, do what they say they do and provide a feature we need. There is sure better way to do it, but clearly there is no point to continue in a branch where nobody look while we can now have broader review and more feedback. -- Cedric BAIL ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! http://pubads.g.doubleclick.net/ gampad/clk?id=1444514301&iu=/ca-pub-7940484522588532 _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
