Revert it then. This is the change I intended to do, and of course I compiled test it. I have nothing, but I'm using clang. This code is correct! Just so I know though, what's the warning?
On Sat, Apr 16, 2016 at 1:13 AM, Andrew Williams <a...@andywilliams.me> wrote: > Agreed, warnings everywhere - looked serious enough that I thought I'd > broken elm_code :( > > Andy > On Fri, 15 Apr 2016 at 19:05, Cedric BAIL <cedric.b...@free.fr> wrote: > > > On Fri, Apr 15, 2016 at 5:53 AM, Tom Hacohen <t...@stosb.com> wrote: > > > tasn pushed a commit to branch master. > > > > > > > > > http://git.enlightenment.org/core/efl.git/commit/?id=7c5f81d30f8f2960862daf912a833a096cef6c6b > > > > > > commit 7c5f81d30f8f2960862daf912a833a096cef6c6b > > > Author: Tom Hacohen <t...@stosb.com> > > > Date: Fri Apr 15 13:52:32 2016 +0100 > > > > > > Eo: Make sure semi-colons and other directives aren't used in > eo_add. > > > > > > This was already enforced in the legacy version but was not > enforced > > in > > > the GCC extension version. This change makes sure it's disallowed > in > > > both. > > > > Is this really the change you wanted to do and did you compile/tests > > it ? I have some serious warning in evas, ector, ecore, ecore_con, > > eldbus, eio, edje and elementary... Basically everyone that is using > > Eo ! Very close to revert this and make some joke about it :-D > > > > > --- > > > src/lib/eo/Eo.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/src/lib/eo/Eo.h b/src/lib/eo/Eo.h > > > index c2c7d4c..1946650 100644 > > > --- a/src/lib/eo/Eo.h > > > +++ b/src/lib/eo/Eo.h > > > @@ -627,7 +627,7 @@ EAPI Eo *_eo_self_get(void); > > > # define _eo_add_common(klass, parent, is_ref, ...) \ > > > ({ \ > > > Eo * const __eo_self = _eo_add_internal_start(__FILE__, __LINE__, > > klass, parent, is_ref, EINA_FALSE); \ > > > - __VA_ARGS__; \ > > > + (void) (0, ##__VA_ARGS__); \ > > > (Eo *) _eo_add_end(eo_self, EINA_FALSE); \ > > > }) > > > > > > > > > -- > > > > > > > > > > > > > > > > > -- > > Cedric BAIL > > > > > > > ------------------------------------------------------------------------------ > > Find and fix application performance issues faster with Applications > > Manager > > Applications Manager provides deep performance insights into multiple > > tiers of > > your business applications. It resolves application problems quickly and > > reduces your MTTR. Get your free trial! > > https://ad.doubleclick.net/ddm/clk/302982198;130105516;z > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > ------------------------------------------------------------------------------ > Find and fix application performance issues faster with Applications > Manager > Applications Manager provides deep performance insights into multiple > tiers of > your business applications. It resolves application problems quickly and > reduces your MTTR. Get your free trial! > https://ad.doubleclick.net/ddm/clk/302982198;130105516;z > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
