[EGIT] [core/efl] master 02/03: psd_loader: Fix bad assumption about signedness of chars

[Derek Foreman]

derekf pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=34ce296cac84980a55a842675c260d32c1a958bd

commit 34ce296cac84980a55a842675c260d32c1a958bd
Author: Derek Foreman <der...@osg.samsung.com>
Date:   Fri Jun 3 16:25:50 2016 -0500

    psd_loader: Fix bad assumption about signedness of chars
    
    Whether "char" is signed or unsigned is architecture dependent, so if we
    know we need a -1 in a char type we must declared it to be signed.
---
 src/modules/evas/image_loaders/psd/evas_image_load_psd.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/modules/evas/image_loaders/psd/evas_image_load_psd.c 
b/src/modules/evas/image_loaders/psd/evas_image_load_psd.c
index 6c8879a..f39fd28 100644
--- a/src/modules/evas/image_loaders/psd/evas_image_load_psd.c
+++ b/src/modules/evas/image_loaders/psd/evas_image_load_psd.c
@@ -200,7 +200,8 @@ read_compressed_channel(const unsigned char *map, size_t 
length, size_t *positio
 {
    // FIXME: what does channel_length means, and why is it not used
    unsigned int i;
-   char headbyte, c;
+   signed char headbyte;
+   unsigned char c;
 
 #define CHECK_RET(Call)                                         \
    if (!Call) return READ_COMPRESSED_ERROR_FILE_READ_ERROR;    \
@@ -502,7 +503,7 @@ get_single_channel(PSD_Header *head,
                   Eina_Bool compressed)
 {
    unsigned int i, bpc;
-   char headbyte;
+   signed char headbyte;
    int c;
    int pixels_count;
 

--