On 7 June 2016 at 18:25, Daniel Kolesa <dan...@octaforge.org> wrote: > On Tue, Jun 7, 2016 at 6:28 AM, Jean-Philippe André <j...@videolan.org> > wrote: > > On 7 June 2016 at 13:53, Hermet Park <her...@hermet.pe.kr> wrote: > > > >> After this chage, > >> entry_cursor_content_get() return type became (const char *) > >> > >> But it shouldn't be. > >> > > > > Looks like eolian needs to know that own(string) means char*. > > > > If we do this, we'll need a new builtin for stringshare (as I proposed > earlier) or things will not work well... (stringshare is always const > even if you take ownership of it). Honestly I don't like dropping > const in this case too much (constness has nothing to do with delete > func) but I can't think of any way. >
So, evas_textblock_cursor_content_get returns a string to free(). This probably needs to return a stringshare instead (with eo apis, that is). D5, own(string) means the caller will have to call eina_stringshare_del? > > D5 > > > > >> > >> -----Original Message----- > >> From: "Felipe Magno de Almeida"<fel...@expertisesolutions.com.br> > >> To: <g...@lists.enlightenment.org>; > >> Cc: > >> Sent: 2016-06-06 (월) 15:05:03 > >> Subject: [EGIT] [core/efl] master 02/08: elm: Fix wrong use of char > >> instead of string and void out parameter > >> > >> felipealmeida pushed a commit to branch master. > >> > >> > >> > http://git.enlightenment.org/core/efl.git/commit/?id=61f52a26fb5a512e77d3141e398182107b1cf752 > >> > >> commit 61f52a26fb5a512e77d3141e398182107b1cf752 > >> Author: Felipe Magno de Almeida <fel...@expertisesolutions.com.br> > >> Date: Mon Jun 6 02:47:15 2016 -0300 > >> > >> elm: Fix wrong use of char instead of string and void out parameter > >> --- > >> src/lib/elementary/elm_entry.c 2 +- > >> src/lib/elementary/elm_entry.eo 4 ++-- > >> 2 files changed, 3 insertions(+), 3 deletions(-) > >> > >> diff --git a/src/lib/elementary/elm_entry.c > >> b/src/lib/elementary/elm_entry.c > >> index 1134ee1..915c03b 100644 > >> --- a/src/lib/elementary/elm_entry.c > >> +++ b/src/lib/elementary/elm_entry.c > >> @@ -4362,7 +4362,7 @@ _elm_entry_cursor_is_visible_format_get(Eo *obj > >> EINA_UNUSED, Elm_Entry_Data *sd) > >> (sd->entry_edje, "elm.text", EDJE_CURSOR_MAIN); > >> } > >> > >> -EOLIAN static char* > >> +EOLIAN static const char* > >> _elm_entry_cursor_content_get(Eo *obj EINA_UNUSED, Elm_Entry_Data *sd) > >> { > >> return edje_object_part_text_cursor_content_get > >> diff --git a/src/lib/elementary/elm_entry.eo > >> b/src/lib/elementary/elm_entry.eo > >> index 69aabe5..f7ab96f 100644 > >> --- a/src/lib/elementary/elm_entry.eo > >> +++ b/src/lib/elementary/elm_entry.eo > >> @@ -628,7 +628,7 @@ class Elm.Entry (Elm.Layout, > Elm.Interface_Scrollable, > >> Evas.Clickable_Interface, > >> Only the text is returned, any format that may exist will > >> not be part > >> of the return value. You must free the string when done > >> with \@ref free. > >> ]] > >> - return: own(char *) @warn_unused; > >> + return: own(string) @warn_unused; > >> } > >> } > >> @property selection { > >> @@ -803,7 +803,7 @@ class Elm.Entry (Elm.Layout, > Elm.Interface_Scrollable, > >> Evas.Clickable_Interface, > >> input_panel_imdata_get @const { > >> [[Get the specific data of the current input panel.]] > >> params { > >> - @out data: void; [[The specific data to be got from the > input > >> panel.]] > >> + @in data: void_ptr; [[The specific data to be got from the > >> input panel.]] > >> @out len: int; [[The length of data.]] > >> } > >> } > >> > >> -- > >> > >> > >> > ------------------------------------------------------------------------------ > >> What NetFlow Analyzer can do for you? Monitors network bandwidth and > >> traffic > >> patterns at an interface-level. Reveals which users, apps, and protocols > >> are > >> consuming the most bandwidth. Provides multi-vendor support for NetFlow, > >> J-Flow, sFlow and other flows. Make informed decisions using capacity > >> planning reports. > https://ad.doubleclick.net/ddm/clk/305295220;132659582;e > >> _______________________________________________ > >> enlightenment-devel mailing list > >> enlightenment-devel@lists.sourceforge.net > >> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > >> > > > > > > > > -- > > Jean-Philippe André > > > ------------------------------------------------------------------------------ > > What NetFlow Analyzer can do for you? Monitors network bandwidth and > traffic > > patterns at an interface-level. Reveals which users, apps, and protocols > are > > consuming the most bandwidth. Provides multi-vendor support for NetFlow, > > J-Flow, sFlow and other flows. Make informed decisions using capacity > > planning reports. > https://ad.doubleclick.net/ddm/clk/305295220;132659582;e > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > ------------------------------------------------------------------------------ > What NetFlow Analyzer can do for you? Monitors network bandwidth and > traffic > patterns at an interface-level. Reveals which users, apps, and protocols > are > consuming the most bandwidth. Provides multi-vendor support for NetFlow, > J-Flow, sFlow and other flows. Make informed decisions using capacity > planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Jean-Philippe André ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
