On 06/09/2016 04:06 PM, Cedric BAIL wrote: > On Thu, Jun 9, 2016 at 11:58 AM, Christopher Michael > <[email protected]> wrote: >> On 06/09/2016 02:52 PM, Cedric BAIL wrote: >>> On Thu, Jun 9, 2016 at 10:50 AM, Derek Foreman <[email protected]> >>> wrote: >>>> derekf pushed a commit to branch master. >>>> >>>> http://git.enlightenment.org/core/efl.git/commit/?id=a4f64d6fcb3de6ff650e9a09b09c69edbb862146 >>>> >>>> commit a4f64d6fcb3de6ff650e9a09b09c69edbb862146 >>>> Author: Derek Foreman <[email protected]> >>>> Date: Thu Jun 9 12:43:50 2016 -0500 >>>> >>>> ecore_wl2: Fix keyboard repeat handling >>>> >>>> Recent timer changes broke keyboard repeat under wayland - while that >>>> will probably be fixed shortly, this should be more robust and >>>> more accurate anyway. >>> >>> After investigating this, we discovered that ecore_wl2 was setting a >>> timer with a repeat of 0s and delay it by 0s. I have no idea of what >>> was the previous behavior of such request, but now it does exactly >>> what you expect... Trigger timer callback as soon and as fast as it >>> can. Enjoy ! >>> >> >> Hmmm, that should not be possible really. When _ecore_wl2_input_add gets >> called, the repeat.rate and repeat.delay are set to some initial values. >> >> What values were getting passed in to the _keyboard_cb_repeat_setup >> function ?? Perhaps some client app is passing us 0 there and we are not >> trapping for that ?? > > Float divided by int give an int, not a float. Result was below 0, so > turned 0 in int. >
Sure. I was just asking if we are indeed getting the proper values sent to _keyboard_cb_repeat_setup. I checked with Derek and it would seem that the values we are getting are ok. I just wanted to be sure that there was not a larger issue here. Cheers, dh ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. https://ad.doubleclick.net/ddm/clk/305295220;132659582;e _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
