On Thu, 16 Jun 2016 11:53:56 -0700 Cedric BAIL <cedric.b...@free.fr> said:
> On Thu, Jun 16, 2016 at 11:29 AM, Tom Hacohen <t...@osg.samsung.com> wrote: > > On 16/06/16 10:47, Carsten Haitzler wrote: > >> On Thu, 16 Jun 2016 14:28:22 +0900 Jean-Philippe André <j...@videolan.org> > >> said: > >>>>> The ON_HOLD flag, now called efl_event_processed_get/set() is a better > >>>>> approach to stop processing events. > >>>> > >>>> That is off topic, but seriously something we should consider asap if > >>>> we want to drop the return type of event. I have not any case in mind > >>>> where returning EINA_FALSE make sense. Should we drop it ? > >>> > >>> I am also thinking we should drop it. > >>> Pretty sure the few places that return EINA_FALSE right now are actually > >>> mistakes and sources of bugs. > >> > >> i think so too. drop the return. > > > > The return is mega useful, though I'm open to implementing it > > differently. The return is there so you can filter events. We currently > > have things like "on_hold" in input events to mark an event has been > > processed and should stop propagating, but the return lets you stop the > > callback. I guess we can change it to be "eo_event_callback_stop(obj)". > > Btw, it shouldn't be a bool, there are defines for the return values. I > > should have typedeffed the type. I'm open to changing to > > eo_event_callback_stop though, just let me know. > > on_hold boolean is gone from efl input event. JP did some magic here > as this would have never worked with bindings, basically using an Eo > object to set the flag. actually the event information *IS* an eo object. yo just get properties from it... this means to set hold ... you just set the property and the same obj is passed into future cb's for that event. :) > Grep for EO_EVENT_STOP, it is already used by code, even code I didn't > > write. :) > > git grep return nothing on efl tree for me. > -- > Cedric BAIL > > ------------------------------------------------------------------------------ > What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic > patterns at an interface-level. Reveals which users, apps, and protocols are > consuming the most bandwidth. Provides multi-vendor support for NetFlow, > J-Flow, sFlow and other flows. Make informed decisions using capacity planning > reports. http://sdm.link/zohomanageengine > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports. http://sdm.link/zohomanageengine _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
