On 07/13/2016 01:08 PM, marcel-hollerb...@t-online.de wrote: > On Wed, Jul 13, 2016 at 08:49:11PM +0900, Carsten Haitzler wrote: >> On Wed, 13 Jul 2016 08:20:15 +0200 marcel-hollerb...@t-online.de said: >> >>> On Wed, Jul 13, 2016 at 08:51:04AM +0900, Carsten Haitzler wrote: >>>> On Tue, 12 Jul 2016 13:40:33 +0200 marcel-hollerb...@t-online.de said: >>>> >>>>> Hello, >>>>> >>>>> this commit breaks wl-apps. They dont receive any mouseinput anymore. >>>>> >>>>> To reproduce, just start terminology in weston. >>>> >>>> actually wl was broken some time ago it seems. the child content was no >>>> longer swallowed into the border frame as it should have been and thus >>>> something that should have been harmless was not. devilhorns fixed this >>>> last night for wl clients. >>> >>> No it worked until this commit. The edje object is just resized >>> efl_ui_win.c:877, it just worked different it was not broken. >> >> it was broken. stacking was broken. in x11 if i placed objects UNDER the >> swallow part then that'd be behind the window content. in wl then EVERYTHING >> would be above window content due to it not being swallowed. swallowing fixes >> this. devilhorns even said that it USEd to be swallowed and somehow is no >> longer swallowed. > > Well the biggest things are fixed now. > > But, i dont really understand what you mean, all objects are created with the > window object as parent, which means that all objects have the same layer. > And honestly, setting the frame layer to one above the window itself, > (as it was before) does make much sense to me, since you can make sure that > all content is below the border, so at least the controls of the window are > still > visible, even if things are going wrong. >
I suppose having the frame border be One layer above does make sense in some context ... that can easily be added back in tho. >> >>> And still, the commit is not really harmless it breaks behaviour, as you >>> have seen... >> >> this is a behaviour bug. that's my take on it. bug reports are "this does not >> do what i expect. it does not do what the mouse_events does - ie be explicit >> on >> swallows. it's different". it's a rare enough corner of things where it >> shouldn't in general create an issue. it ONLY created an issue with wayland >> because wayland had broken/changed how it swallows/handles window content >> objects and stopped swallowing into the border object. > > Back to the topic of the behaviour change, even if the change is > good or bad, there is not even a @fix mark so i guess it will not be > part of the changelog or anything. So from the POV from a api user, its > a bad change, he doesnt even get told that there was a behaviour change. > Yea. That's my fault :/ missed adding the @fix there. dh > And once again, this commit wasnt exposing a problem in the wl code. It > created a problem, the bahviour was there before. It worked. Now it > doesnt. And its completly the same for every single user which used this > bahaviour. > >> >>>>> Greetings >>>>> bu5hm4n >>>>> >>>>> On Mon, Jul 11, 2016 at 06:53:49PM -0700, Shinwoo Kim wrote: >>>>>> raster pushed a commit to branch master. >>>>>> >>>>>> http://git.enlightenment.org/core/efl.git/commit/?id=c52eda0bf155b11ca137450cb388cd239d434554 >>>>>> >>>>>> commit c52eda0bf155b11ca137450cb388cd239d434554 >>>>>> Author: Shinwoo Kim <cinoo....@samsung.com> >>>>>> Date: Tue Jul 12 10:53:27 2016 +0900 >>>>>> >>>>>> edje: the repeat_events property of swallowed object probably should >>>>>> follow the repeat_events property of swallow part object >>>>>> Summary: Need discussion about the repeat_events property >>>>>> >>>>>> Test Plan: Swallow an object which has EINA_TRUE repeat_events to a >>>>>> swallow part which has EINA_FALSE repeat_events >>>>>> Reviewers: Hermet, cedric, raster, jpeg >>>>>> >>>>>> Reviewed By: raster, jpeg >>>>>> >>>>>> Subscribers: jaehwan, seoz, woohyun >>>>>> >>>>>> Differential Revision: https://phab.enlightenment.org/D3580 >>>>>> --- >>>>>> src/lib/edje/edje_util.c | 3 +-- >>>>>> 1 file changed, 1 insertion(+), 2 deletions(-) >>>>>> >>>>>> diff --git a/src/lib/edje/edje_util.c b/src/lib/edje/edje_util.c >>>>>> index 4f82e32..48ee448 100644 >>>>>> --- a/src/lib/edje/edje_util.c >>>>>> +++ b/src/lib/edje/edje_util.c >>>>>> @@ -6625,8 +6625,7 @@ _edje_real_part_swallow(Edje *ed, >>>>>> if (rp->part->mouse_events) >>>>>> { >>>>>> _edje_callbacks_add(obj_swallow, ed, rp); >>>>>> - if (rp->part->repeat_events) >>>>>> - evas_object_repeat_events_set(obj_swallow, 1); >>>>>> + evas_object_repeat_events_set(obj_swallow, >>>>>> rp->part->repeat_events); if (rp->part->pointer_mode != >>>>>> EVAS_OBJECT_POINTER_MODE_AUTOGRAB) evas_object_pointer_mode_set >>>>>> (obj_swallow, rp->part->pointer_mode); evas_object_pass_events_set >>>>>> (obj_swallow, 0); >>>>>> >>>>>> -- >>>>>> >>>>>> >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> What NetFlow Analyzer can do for you? Monitors network bandwidth and >>>>> traffic patterns at an interface-level. Reveals which users, apps, and >>>>> protocols are consuming the most bandwidth. Provides multi-vendor support >>>>> for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using >>>>> capacity planning reports.http://sdm.link/zohodev2dev >>>>> _______________________________________________ >>>>> enlightenment-devel mailing list >>>>> enlightenment-devel@lists.sourceforge.net >>>>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel >>>>> >>>> >>>> >>>> -- >>>> ------------- Codito, ergo sum - "I code, therefore I am" -------------- >>>> The Rasterman (Carsten Haitzler) ras...@rasterman.com >>>> >>> >> >> >> -- >> ------------- Codito, ergo sum - "I code, therefore I am" -------------- >> The Rasterman (Carsten Haitzler) ras...@rasterman.com >> > ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports.http://sdm.link/zohodev2dev _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
