devilhorns pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=30ab0a89be3cfc601d2e93d8a165f2e38eaf907b
commit 30ab0a89be3cfc601d2e93d8a165f2e38eaf907b Author: Chris Michael <[email protected]> Date: Thu Jul 21 12:53:13 2016 -0400 elementary: Remove logically dead code Coverity reports that this is logically dead code. As eo_item has been dereferenced on all paths leading here, and it is also set above, then it cannot be NULL at this point, thus this check is logically dead. Fixes Covierty CID1355585 @fix Signed-off-by: Chris Michael <[email protected]> --- src/lib/elementary/elm_index.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/lib/elementary/elm_index.c b/src/lib/elementary/elm_index.c index 665ea7f..edc4abd 100644 --- a/src/lib/elementary/elm_index.c +++ b/src/lib/elementary/elm_index.c @@ -1544,8 +1544,7 @@ _elm_index_item_sorted_insert(Eo *obj, Elm_Index_Data *sd, const char *letter, E elm_interface_atspi_accessible_children_changed_added_signal_emit(obj, eo_item); } - if (!eo_item) return NULL; - else return eo_item; + return eo_item; } EOLIAN static Elm_Object_Item* --
