hermet pushed a commit to branch master.

http://git.enlightenment.org/tools/enventor.git/commit/?id=96c767611b9c2b0ee71f3d43597afbf4523606cf

commit 96c767611b9c2b0ee71f3d43597afbf4523606cf
Author: Hermet Park <[email protected]>
Date:   Wed Aug 3 00:55:40 2016 +0900

    file_tab: fix a crash issue.
    
    when user close a non selected file tab item,
    Enventor occasionaly has a crash.
    As investested, it seemed like an EFL issue.
    But we can easily fix this by moving the function call.
---
 src/bin/file_tab.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/bin/file_tab.c b/src/bin/file_tab.c
index 0f5d963..336e040 100644
--- a/src/bin/file_tab.c
+++ b/src/bin/file_tab.c
@@ -67,6 +67,10 @@ file_tab_it_del(file_tab_it *fti)
 {
    Evas_Object *list = elm_object_item_widget_get(fti->it);
 
+   //Be aware, if you change this api call order, it may break enventor.
+   //Just keep this here as possible.
+   enventor_item_del(fti->enventor_it);
+
    //FIXME: If this item is main, then it needs to close project.
 
    //If the focused item is removed, then enable next item.
@@ -88,7 +92,6 @@ file_tab_it_del(file_tab_it *fti)
 
    //Remove item.
    elm_object_item_del(fti->it);
-   enventor_item_del(fti->enventor_it);
    free(fti);
 
    elm_list_go(list);

-- 


Reply via email to