davemds pushed a commit to branch master.

http://git.enlightenment.org/bindings/python/python-efl.git/commit/?id=ffb294b82f017513d9127c84046c58c7f34364ce

commit ffb294b82f017513d9127c84046c58c7f34364ce
Author: Dave Andreoli <[email protected]>
Date:   Mon Aug 8 15:29:01 2016 +0200

    dbus: remove unused code
    
    refcount is never incremented nor used, thus the connection was never 
properly closed
    
    ...shutdown bug still there
---
 efl/dbus_mainloop/e_dbus.c | 1 -
 efl/dbus_mainloop/e_dbus.h | 1 -
 2 files changed, 2 deletions(-)

diff --git a/efl/dbus_mainloop/e_dbus.c b/efl/dbus_mainloop/e_dbus.c
index 70d6517..784f093 100644
--- a/efl/dbus_mainloop/e_dbus.c
+++ b/efl/dbus_mainloop/e_dbus.c
@@ -439,7 +439,6 @@ e_dbus_connection_close(E_DBus_Connection *conn)
       close_connection++;
       return;
    }
-   if (--(conn->refcount) != 0) return;
 
    dbus_connection_free_data_slot(&connection_slot);
    dbus_connection_set_watch_functions(conn->conn,
diff --git a/efl/dbus_mainloop/e_dbus.h b/efl/dbus_mainloop/e_dbus.h
index 723c3e9..f9a0f13 100644
--- a/efl/dbus_mainloop/e_dbus.h
+++ b/efl/dbus_mainloop/e_dbus.h
@@ -35,7 +35,6 @@ struct E_DBus_Connection
   Eina_List *fd_handlers;
   Eina_List *timeouts;
   Ecore_Idler *idler;
-  int refcount;
 };
 
 struct E_DBus_Handler_Data

-- 


Reply via email to