On Sat, Aug 13, 2016 at 4:39 AM Carsten Haitzler <ras...@rasterman.com>
wrote:

> raster pushed a commit to branch master.
>
>
> http://git.enlightenment.org/core/enlightenment.git/commit/?id=8d780c7fb5ccb04c49c98370c9e4ec7a2440bbb1
>
> commit 8d780c7fb5ccb04c49c98370c9e4ec7a2440bbb1
> Author: Carsten Haitzler (Rasterman) <ras...@rasterman.com>
> Date:   Sat Aug 13 17:39:17 2016 +0900
>
>     e sudo gui support - add askpass util for sudo askpass support
>
>     this gives e by default sudo gui support with an askpass util that
>     sudo can use as well as setting the env var correctly so it will be
>     used by sudo.
>
>     @feature
> ---
>  configure.ac                               |   4 +
>  data/desktop/Makefile.mk                   |   3 +-
>  data/desktop/enlightenment_askpass.desktop |  12 +++
>  data/icons/Makefile.mk                     |   6 ++
>  data/icons/enlightenment-askpass.png       | Bin 0 -> 696 bytes
>  src/bin/.gitignore                         |   1 +
>  src/bin/Makefile.mk                        |   9 +-
>  src/bin/e_askpass_main.c                   | 142
> +++++++++++++++++++++++++++++
>  src/bin/e_main.c                           |   2 +
>  9 files changed, 177 insertions(+), 2 deletions(-)
>
>


> diff --git a/src/bin/e_main.c b/src/bin/e_main.c
> index 28ed4bc..4c705fc 100644
> --- a/src/bin/e_main.c
> +++ b/src/bin/e_main.c
> @@ -325,6 +325,8 @@ main(int argc, char **argv)
>     e_util_env_set("E_RESTART_OK", NULL);
>     e_util_env_set("PANTS", "ON");
>     e_util_env_set("DESKTOP", "Enlightenment");
> +   snprintf(buff, sizeof(buff), "%s/enlightenment_askpass",
> e_prefix_bin_get());
> +   e_util_env_set("SUDO_ASKPASS", buff);
>     TS("Environment Variables Done");
>
>     /* KDE5 applications don't understand anything other then gnome or
> kde     */
>
>
Ignoring some unusual style and whitespace-related choices in the rest of
the commit, globally setting SUDO_ASKPASS and forcing a gui popup any time
a user runs sudo in a terminal seems a bit excessive. Perhaps that's just
me?
------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity 
planning reports. http://sdm.link/zohodev2dev
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to