barbieri pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=c88b027dc1ac0ffa17022ebebdad1f10687622a3
commit c88b027dc1ac0ffa17022ebebdad1f10687622a3 Author: Gustavo Sverzut Barbieri <[email protected]> Date: Thu Aug 18 01:01:25 2016 -0300 efl_loop_user: error if parent is not a loop provider. it was silently ignoring the parent, which led me to hours trying to investigate why my code wasn't working just to realize my parent wasn't being assigned and refcounts were screwed. --- src/lib/ecore/efl_loop_user.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/lib/ecore/efl_loop_user.c b/src/lib/ecore/efl_loop_user.c index 78ac3a8..530772f 100644 --- a/src/lib/ecore/efl_loop_user.c +++ b/src/lib/ecore/efl_loop_user.c @@ -21,7 +21,10 @@ static void _efl_loop_user_efl_object_parent_set(Eo *obj, Efl_Loop_User_Data *pd EINA_UNUSED, Efl_Object *parent) { if (parent != NULL && efl_provider_find(parent, EFL_LOOP_CLASS) == NULL) - return ; + { + ERR("parent=%p is not a provider of EFL_LOOP_CLASS!", parent); + return; + } efl_parent_set(efl_super(obj, EFL_LOOP_USER_CLASS), parent); } --
