Sorry I didn't give reasoning: 23:54 < thomasg> netstar: is there any actual reason why you dislike supporting xdg thumb, apart from you disliking freedesktop and linux in general? 23:54 < netstar> uh oh! 23:56 < netstar> mmmm they're not really thumbnails... 23:56 < netstar> also it's continuity with other stuff 23:58 < netstar> also I wouldnt say I dislike Linux, I guess...I like choice and the old saying about "eggs and baskets..."
On Mon, Aug 22, 2016 at 11:55 PM, thomasg <tho...@gstaedtner.net> wrote: > On Mon, Aug 22, 2016 at 11:54 PM, Stephen Houston <smhousto...@gmail.com> > wrote: > > > The concern here with XDG is portability. Feel free to discuss. And go. > > > I understand that concern, but I don't think it is valid. > On linux freedesktop.org (XDG) standards are widely adhered to, and for > platforms that don't follow them it is as easy as keeping the old line > behind an "else". > Breaks nothing, works everywhere, and adds interoperability with other > linux tools which could avoid keeping multiple copys of thumbnails around. > There's nothing more involved but checking for a set environment variable. > Actually ephoto already includes efreet_mime support which initializes an > XDG support library, which is far more invasive than using the > XDG_CACHE_HOME env variable would be. > > Although when using the xdg thumb spec, it would also be wise to use their > actual thumbnailing scheme, which is - in my opinion - reasonable, but I > don't know if you're interested in it. > > All in all, I don't care _that_ much, I just usually prefer if applications > adhere to existing standards if these are reasonable -- which can be said > about the xdg thumbnailing spec imho. > > If there's interest, I'd be willing to implement the spec and send a patch > for review. > > > > > > On Aug 22, 2016 4:49 PM, "thomasg" <tho...@gstaedtner.net> wrote: > > > >> On Mon, Aug 22, 2016 at 10:41 PM, Stephen okra Houston < > >> smhousto...@gmail.com> wrote: > >> > >>> okra pushed a commit to branch master. > >>> > >>> http://git.enlightenment.org/apps/ephoto.git/commit/?id=8134 > >>> 71f9bd6048026b372b4b55b303a311d4335e > >>> > >>> commit 813471f9bd6048026b372b4b55b303a311d4335e > >>> Author: Stephen okra Houston <smhousto...@gmail.com> > >>> Date: Mon Aug 22 15:41:28 2016 -0500 > >>> > >>> Ephoto: Save thumbnails in $HOME/.thumbnails > >>> --- > >>> src/bin/ephoto_thumbnailer.c | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/src/bin/ephoto_thumbnailer.c > b/src/bin/ephoto_thumbnailer.c > >>> index 0fe190e..3ea8709 100644 > >>> --- a/src/bin/ephoto_thumbnailer.c > >>> +++ b/src/bin/ephoto_thumbnailer.c > >>> @@ -88,7 +88,7 @@ main(int argc, > >>> ecore_file_init(); > >>> ecore_ipc_init(); > >>> > >>> - snprintf(_thumbdir, PATH_MAX, "%s/.config/ephoto/thumbnails", > >>> getenv("HOME")); > >>> + snprintf(_thumbdir, PATH_MAX, "%s/.thumbnails", getenv("HOME")); > >>> ecore_file_mkpath(_thumbdir); > >>> > >>> if (_e_ipc_init()) ecore_main_loop_begin(); > >>> > >>> -- > >>> > >>> > >>> > >> Hi okra, > >> > >> I think it would be best here to comply to the existing XDG standard > >> regarding to thumbnail caching. > >> https://specifications.freedesktop.org/thumbnail-spec/thumbn > >> ail-spec-latest.html#DIRECTORY > >> Basically just check if XDG_CACHE_HOME exists, if so put it there, else > >> keep it like you have it now. > >> > >> Regards, > >> > >> thomasg > >> > > > ------------------------------------------------------------ > ------------------ > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel