I would, but I wrote it so long ago that I have zero memories of anything related to it. I tested against ssh/d and that was enough then, so I'd guess it should be enough to verify anything you do now.
On Mon, Sep 19, 2016 at 1:22 PM Gustavo Sverzut Barbieri <barbi...@gmail.com> wrote: > Nice zmike, > > Then I'm leaving it out and I kindly request that you give it a review, or > at least a test since likely you found some bugs during your development > and you can check if I had them in my code. > > > Em segunda-feira, 19 de setembro de 2016, Michael Blumenkrantz < > michael.blumenkra...@gmail.com> escreveu: > >> On Sun, 18 Sep 2016 23:21:38 -0300 >> Gustavo Sverzut Barbieri <barbi...@gmail.com> wrote: >> >> > Hi all, >> > >> > I'm implementing the proxy for the new efl_net API and while reading >> > the old code and the SOCKS spec I'm confused about the bind usage. >> > >> > According to the spec https://tools.ietf.org/html/rfc1928: >> > >> > The BIND request is used in protocols which require the client to >> > accept connections from the server. FTP is a well-known example, >> > which uses the primary client-to-server connection for commands and >> > status reports, but may use a server-to-client connection for >> > transferring data on demand (e.g. LS, GET, PUT). >> > >> > It is expected that the client side of an application protocol will >> > use the BIND request only to establish secondary connections after a >> > primary connection is established using CONNECT. In is expected that >> > a SOCKS server will use DST.ADDR and DST.PORT in evaluating the BIND >> > request. >> > >> > This does not work to create a random server via the proxy, after all >> > you can't accept multiple connections. >> > >> > In old code, to enable bind one had to call >> > ecore_con_socks_bind_set(), but none of efl.git does that. Likely that >> > is untested. >> > >> > Then I'm wondering if I should bother to implement this at all. The >> > code to implement it is not that much, but it won't be used unless I >> > can understand how to expose this in our API, currently we can connect >> > to some server (ie: Efl.Net.Dialer) or be the server (ie: >> > Efl.Net.Server), there is no "dialer that connect back", not eve sure >> > how to call that braindead idea of FTP :-/ >> > >> > >> > >> >> I wrote all the existing SOCKS code in ecore. My tests (many years ago) >> of all the apis were against openssh. >> >> I added it for completeness at the time since I was primarily doing the >> client-side parts. I'm skeptical that it would ever be used. >> > > -- > Gustavo Sverzut Barbieri > -------------------------------------- > Mobile: +55 (16) 99354-9890 > > > ------------------------------------------------------------------------------ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
