On Mon, 19 Sep 2016 13:18:47 +0100 Tom Hacohen <t...@osg.samsung.com> said:

> On 19/09/16 13:08, Stefan Schmidt wrote:
> > stefan pushed a commit to branch master.
> >
> > http://git.enlightenment.org/core/efl.git/commit/?id=c25d4e8325b428122439860f9d49dd25a4b4b66d
> >
> > commit c25d4e8325b428122439860f9d49dd25a4b4b66d
> > Author: Stefan Schmidt <ste...@osg.samsung.com>
> > Date:   Mon Sep 19 14:01:19 2016 +0200
> >
> >     tests: ecore: relax the timing precision for the promise timeout test
> >
> >     This test has been failing on Jenkins again and again. After adding the
> > debug a while ago it now shows that the value is between 0.01 and 0.02 in
> > all cases I have seen. Relaxing the timeout here a bit to make it pass in
> > situation where our CI is under load.
> > ---
> >  src/tests/ecore/ecore_test_timer.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/tests/ecore/ecore_test_timer.c
> > b/src/tests/ecore/ecore_test_timer.c index c7547e4..f3b277b 100644
> > --- a/src/tests/ecore/ecore_test_timer.c
> > +++ b/src/tests/ecore/ecore_test_timer.c
> > @@ -183,8 +183,8 @@ _ecore_promise_quit(void *data, const Efl_Event *ev)
> >     double *start = success->value;
> >     double delta = ecore_loop_time_get() - *start;
> >
> > -   fprintf(stderr, "Ecore promise timeout took %f (should be <= 0.01)\n",
> > delta - 0.2);
> > -   fail_if(delta - 0.2 > 0.01);
> > +   fprintf(stderr, "Ecore promise timeout took %f (should be <= 0.02)\n",
> > delta - 0.2);
> > +   fail_if(delta - 0.2 > 0.02);
> >
> >     *bob = EINA_TRUE;
> >     ecore_main_loop_quit();
> >
> 
> 
> Why is there an fprintf there? We don't do it in any other tests. That 
> text should be either removed or moved to a comment. No?

we do this in lots of tests. well printfs. also eina log's too. i make use of
them all the time to run a test by hand to see what is actually going on in the
test.


-- 
------------- Codito, ergo sum - "I code, therefore I am" --------------
The Rasterman (Carsten Haitzler)    ras...@rasterman.com


------------------------------------------------------------------------------
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to