On Sep 21, 2016 4:18 AM, "Carsten Haitzler" <[email protected]> wrote: > > raster pushed a commit to branch master. > > http://git.enlightenment.org/core/enlightenment.git/commit/?id=5861d9bef949c64cbc7ddad31b4ac2cc70bb6440 > > commit 5861d9bef949c64cbc7ddad31b4ac2cc70bb6440 > Author: Carsten Haitzler (Rasterman) <[email protected]> > Date: Wed Sep 21 20:18:01 2016 +0900 > > protect against non-nul terminated string from mmap in filepreview > > this should address 2nd gdb bt and fix T4543
No ! This patch is unnecessary or more exactly too late. Previous code was using the _n variant of append which call strlen. The current code only rely on the given length. Will revert. > @fix > --- > src/bin/e_widget_filepreview.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/src/bin/e_widget_filepreview.c b/src/bin/e_widget_filepreview.c > index 2602895..1f91073 100644 > --- a/src/bin/e_widget_filepreview.c > +++ b/src/bin/e_widget_filepreview.c > @@ -931,8 +931,13 @@ _e_wid_fprev_preview_txt_map_success(void *data, Eio_File *handler EINA_UNUSED, > char *msg; > Evas_Coord mw, mh; > > + msg = malloc(length + 1); > + if (!msg) return; > + strncpy(msg, map, length); > + msg[length] = 0; > buf = eina_strbuf_new(); > - eina_strbuf_append_length(buf, map, length); > + eina_strbuf_append_length(buf, msg, length); > + free(msg); > msg = evas_textblock_text_utf8_to_markup(NULL, eina_strbuf_string_get(buf)); > eina_strbuf_reset(buf); > > > -- > > ------------------------------------------------------------------------------ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
