Hello. On 21/09/16 20:50, Yeshwanth Reddivari wrote: > cedric pushed a commit to branch master. > > http://git.enlightenment.org/core/efl.git/commit/?id=7b90e1147442d6a8023422400bffd77e2815fe0b > > commit 7b90e1147442d6a8023422400bffd77e2815fe0b > Author: Yeshwanth Reddivari <r.yeshwa...@samsung.com> > Date: Wed Sep 21 10:37:59 2016 -0700 > > emotion: convert Emotion_Object into Efl.Canvas.Video > > Reviewers: singh.amitesh, raster, jpeg, cedric > > Differential Revision: https://phab.enlightenment.org/D3994 > > Signed-off-by: Cedric BAIL <ced...@osg.samsung.com> > --- > src/Makefile_Emotion.am | 2 +- > src/lib/efl/interfaces/efl_player.eo | 4 +- > src/lib/elementary/efl_ui_video.c | 20 +- > src/lib/elementary/elc_player.c | 12 +- > src/lib/emotion/Emotion_Eo.h | 2 +- > src/lib/emotion/Emotion_Legacy.h | 3 +- > .../{emotion_object.eo => efl_canvas_video.eo} | 50 ++- > src/lib/emotion/emotion_smart.c | 344 > ++++++++++++--------- > src/modules/ethumb/emotion/emotion.c | 28 +- > src/tests/emotion/emotion_test_main-eo.c | 22 +- > 10 files changed, 261 insertions(+), 226 deletions(-)
Advertising
For such a big change I would remind author as well as reviewers to also run make examples. Also grepping through the repo if any old event names are still used is a good way to spot places that have not been converted. The emotion module for libvlc was such a place. Luckily Jenkins builds. Both problems fixed and pushed. regards Stefan Schmidt ------------------------------------------------------------------------------ _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
