devilhorns pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=61643e6a06630f129f4ac5f2fabd0e26a5a4aa7b
commit 61643e6a06630f129f4ac5f2fabd0e26a5a4aa7b
Author: Chris Michael <cp.mich...@samsung.com>
Date: Thu Oct 13 12:43:44 2016 -0400
evas: Fix missing varargs cleanup
This patch fixes Coverity CID1364123 which reports that (in some
cases) va_end was not being called for var args. As they were
previously initialized with va_start, then va_end should be getting
called.
@fix
Signed-off-by: Chris Michael <cp.mich...@samsung.com>
---
src/lib/evas/canvas/evas_object_intercept.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/lib/evas/canvas/evas_object_intercept.c
b/src/lib/evas/canvas/evas_object_intercept.c
index 13b9a96..d199add 100644
--- a/src/lib/evas/canvas/evas_object_intercept.c
+++ b/src/lib/evas/canvas/evas_object_intercept.c
@@ -204,10 +204,10 @@ _evas_object_intercept_call(Evas_Object *eo_obj,
Evas_Object_Intercept_Cb_Type c
if (!internal)
{
if (_efl_canvas_object_clip_unset_block(eo_obj, obj))
- return 1;
+ goto end_block;
}
- if (!obj->interceptors) return 0;
- return evas_object_intercept_call_clip_unset(eo_obj, obj);
+ if (!obj->interceptors) goto end_noblock;
+ blocked = evas_object_intercept_call_clip_unset(eo_obj, obj);
}
va_end(args);
--
