On 14 October 2016 at 17:00, Stefan Schmidt <ste...@osg.samsung.com> wrote:

> Hello.
>
> On 14/10/16 07:06, Jean-Philippe ANDRÉ wrote:
> > jpeg pushed a commit to branch efl-1.18.
> >
> > http://git.enlightenment.org/core/efl.git/commit/?id=
> 577fa188f5b338dedddb8fef66323155178c4528
> >
> > commit 577fa188f5b338dedddb8fef66323155178c4528
> > Author: Jean-Philippe Andre <jp.an...@samsung.com>
> > Date:   Thu Oct 13 17:59:13 2016 +0900
> >
> >     evas: Fix evas_object_smart_clipped_clipper_get
> >
> >     This was broken for smart objects that are not "clipped smart
> >     objects". This fixes the example evas_smart_object.
> >
> >     NOTE: This EAPI was removed in efl-1.18!
> >     /!\ This was an uncaught API break between 1.17 and 1.18 /!\
> >
> >     @fix
>
>
> *sigh*
>
> Thanks for finding and fixing it. I will roll a 1.18.2 early next week
> to get a fixed release out.
>
>
No one realised there was a missing API. The ABI checker couldn't spot it
either, because there was no ABI break. Only the declaration was missing
but the symbol was there. Thus the function call was returning an int (4
bytes) instead of Eo * (8 bytes).

But in fact the implementation was wrong (my fault!) so I also fixed that :)

-- 
Jean-Philippe André
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to