jackdanielz pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=a86e79141edb61f265b933cdb02cd637a345ab35

commit a86e79141edb61f265b933cdb02cd637a345ab35
Author: Jean-Philippe Andre <[email protected]>
Date:   Tue Nov 1 15:49:20 2016 +0900

    elm: Fix disappearance of some elm images
    
    After the commit 97c9fa64a461c (Remove group_show and group_hide),
    some Efl.Ui.Image objects would not render properly. The reason
    being that the object call to show() was aborted too early when
    the image is still preloading.
    
    This made for really random results as an image preload could
    take more or less time, depending on chance.
---
 src/lib/elementary/efl_ui_image.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/lib/elementary/efl_ui_image.c 
b/src/lib/elementary/efl_ui_image.c
index 2e75cbe..b2d3aa4 100644
--- a/src/lib/elementary/efl_ui_image.c
+++ b/src/lib/elementary/efl_ui_image.c
@@ -598,9 +598,10 @@ static void
 _efl_ui_image_show(Eo *obj, Efl_Ui_Image_Data *sd)
 {
    sd->show = EINA_TRUE;
-   if (sd->preload_status == EFL_UI_IMAGE_PRELOADING) return;
 
    efl_gfx_visible_set(efl_super(obj, MY_CLASS), EINA_TRUE);
+
+   if (sd->preload_status == EFL_UI_IMAGE_PRELOADING) return;
    efl_gfx_visible_set(sd->img, EINA_TRUE);
    ELM_SAFE_FREE(sd->prev_img, evas_object_del);
 }

-- 


Reply via email to