Hello. I think that code, that uses pipe() should be moved to using ecore_pipe. Because ecore_pipe is already support both of behaviours for windows and posix in the similar way. Similar code uses in ecore_anim module. All this should be unified, of course.
About eina_socket - sound reasonable. On Fri, 2016-11-04 at 11:00 +0100, Vincent Torri wrote: > my opinion is that it should be in eina, actually. An abstraction of > sockets, that could be used in ecore_pipe and in ecore_con and > everywhere else > > Vincent > > > On Fri, Nov 4, 2016 at 10:22 AM, Stefan Schmidt <[email protected] > om> wrote: > > Hello. > > > > On 04/11/16 10:16, Mykyta Biliavskyi wrote: > > > nikawhite pushed a commit to branch master. > > > > > > http://git.enlightenment.org/core/efl.git/commit/?id=132bac98c8a7 > > > 7adde5a8271c48ed0d3c7dfb6563 > > > > > > commit 132bac98c8a77adde5a8271c48ed0d3c7dfb6563 > > > Author: Mykyta Biliavskyi <[email protected]> > > > Date: Fri Nov 4 11:06:11 2016 +0200 > > > > > > Evas events: fix for works with pipes on windows. > > > > > > Evil implementation of pipe() function uses sockets. Windows > > > functions > > > "write", "read" and "close" doesn't works with sockets. In > > > this commit > > > added macros, that replace "read" with "recv", "write" with > > > "send" and > > > "close" with "closesocket". > > > > > > @fix > > > --- > > > src/lib/evas/canvas/evas_async_events.c | 30 > > > +++++++++++++++++++++++++----- > > > 1 file changed, 25 insertions(+), 5 deletions(-) > > > > From a platform abstraction view I would think something like this > > should be handled in evil and not in some random files all over the > > code > > base. > > > > There might be other parts of the code having the same problem (if > > not > > now they might get introduced later) and having the handling > > directly > > in the abstraction layer will avoid that you have to patch every > > file > > that comes with it. > > > > regards > > Stefan Schmidt > > > > ----------------------------------------------------------------- > > ------------- > > Developer Access Program for Intel Xeon Phi Processors > > Access to Intel Xeon Phi processor-based developer platforms. > > With one year of Intel Parallel Studio XE. > > Training and support from Colfax. > > Order your platform today. http://sdm.link/xeonphi > > _______________________________________________ > > enlightenment-devel mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > ------------------------------------------------------------------- > ----------- > Developer Access Program for Intel Xeon Phi Processors > Access to Intel Xeon Phi processor-based developer platforms. > With one year of Intel Parallel Studio XE. > Training and support from Colfax. > Order your platform today. http://sdm.link/xeonphi > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
