It should. Got lazy because they are highly unlikely error. Will fix that. Cedric
On Fri, Nov 11, 2016 at 10:15 AM, Jean Guyomarc'h <jean.guyoma...@gmail.com> wrote: > Shouldn't these return anything but 0? If these are in main(), > returning 0 would mean the program terminated successfully, which is > not the case here. > Jean > > > On Fri, Nov 11, 2016 at 6:54 PM, Shuhrat Dehkanov <k...@efir.uz> wrote: >> cedric pushed a commit to branch master. >> >> http://git.enlightenment.org/tools/clouseau.git/commit/?id=9f62d5914032c3d159f40b8e32e1901b145ec654 >> >> commit 9f62d5914032c3d159f40b8e32e1901b145ec654 >> Author: Shuhrat Dehkanov <k...@efir.uz> >> Date: Fri Nov 11 09:47:01 2016 -0800 >> >> return 0 from main() >> >> Summary: >> Although, underlying value of EINA_FALSE is 0 the type former is Bool. >> Hence, for the sake of consistency, let's return 0 from main(). >> >> Reviewers: jeanguyomarch, jeyzu >> >> Subscribers: hyunseok, minkyu >> >> Differential Revision: https://phab.enlightenment.org/D4392 >> >> Signed-off-by: Cedric Bail <ced...@osg.samsung.com> >> --- >> src/bin/clouseau_client.c | 2 +- >> src/bin/clouseaud.c | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/src/bin/clouseau_client.c b/src/bin/clouseau_client.c >> index 32fcb0a..7d57fe4 100644 >> --- a/src/bin/clouseau_client.c >> +++ b/src/bin/clouseau_client.c >> @@ -2390,7 +2390,7 @@ main(int argc, char **argv) >> if (_clouseau_client_log_dom < 0) >> { >> EINA_LOG_ERR("Could not register log domain: %s", log_dom); >> - return EINA_FALSE; >> + return 0; >> } >> >> Evas_Object *win, *panes, *frame; >> diff --git a/src/bin/clouseaud.c b/src/bin/clouseaud.c >> index aa43089..93d57f8 100644 >> --- a/src/bin/clouseaud.c >> +++ b/src/bin/clouseaud.c >> @@ -403,7 +403,7 @@ int main(void) >> if (_clouseaud_log_dom < 0) >> { >> EINA_LOG_ERR("Could not register log domain: %s", log_dom); >> - return EINA_FALSE; >> + return 0; >> } >> >> if (!(server = ecore_con_server_add(ECORE_CON_REMOTE_TCP | >> ECORE_CON_SOCKET_ACTIVATE, >> >> -- >> >> > > ------------------------------------------------------------------------------ > Developer Access Program for Intel Xeon Phi Processors > Access to Intel Xeon Phi processor-based developer platforms. > With one year of Intel Parallel Studio XE. > Training and support from Colfax. > Order your platform today. http://sdm.link/xeonphi > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Cedric BAIL ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
