Hi,
I have pushed a "fix" but I don't like it. All it does is disable shadows
and fix the opaque/input region of the window as exposed to Wayland, and
fix a 1 pixel offset in the theme.
I don't like it because --IMHO-- E should not have SSD (server-side
decorations) in Wayland. Also I don't like it because 1 pixel difference in
a reported geometry should be completely unrelated to whether decorations
are used or not. That 1 pixel made all the difference: look & input.
Anyway, sorry for the breakage, that I could indeed have avoided by testing
more.
Best regards,
On 24 November 2016 at 14:27, Jean-Philippe André <j...@videolan.org> wrote:
> Hey,
>
> On 24 November 2016 at 00:09, Mike Blumenkrantz <
> michael.blumenkra...@gmail.com> wrote:
>
>> Hi,
>>
>> Mouse eventing works under Wayland compositors by
>> calling wl_pointer_send_button() on a surface resource. The client then
>> receives this event and handles it appropriately, in our case by
>> propagating it ecore-wl2 -> ecore-input-evas -> evas.
>>
>
> Hmm I'm more wondering about how this works for internal windows. There
> seems to be an input rectangle for windows that have an input region
> different than their actual geometry (shadow, etc...). I'll have a close
> look at it this afternoon.
>
>
> I would hope that in future cases of significant patches being pushed, a
>> bit more testing can be done in Wayland mode to avoid noticeable breakages
>> like this.
>>
>
> Yes, I'm really sorry that this broke those things. I hope you can
> understand though that the point of merging my work was to find out those
> issues and work on them rather than piling more patches and accumulating
> potential issues in my corner. My bad for not testing E Wayland, even
> though I have a VM for that.
>
>
> On Wed, Nov 23, 2016 at 9:56 AM Jean-Philippe André <j...@videolan.org>
>> wrote:
>>
>> > Hi,
>> >
>> > As of now, I know that these patches have broken the following things:
>> > 1. E internal windows in E Wayland. The borders had disappeared
>> ("fixed")
>> > but mouse inputs still don't work.
>> > 2. Window border shows EFL CSD + system decorations on Ubuntu (?)
>> >
>> > For 1. I need help from E/WL experts. I can see a MOUSE_DOWN event
>> happen
>> > on a single object (the smart obj for the window frame). But I have to
>> > admit that I'm very confused. How is this object supposed to propagate
>> the
>> > event to the window itself? Anyway I pushed a hacky patch. Needs to be
>> > properly fixed of course.
>> >
>> > Best regards,
>> >
>> >
>> >
>> > On 23 November 2016 at 14:23, Jean-Philippe André <j...@videolan.org>
>> > wrote:
>> >
>> > > Hello everyone,
>> > >
>> > >
>> > > First of all, sorry to send this mail after pushing my changes, rather
>> > > than before. But I prefer spotting issues and fixing them rather than
>> > > having to worry about everything during the design & implementation
>> > phase.
>> > >
>> > >
>> > > I have been working on a new interface for the Window API, and this
>> > > includes a lot of changes to the theme as well. In particular, win.edc
>> > (the
>> > > win group) is now barely used at all, while border.edc (the CSD frame
>> > > group) contains a lot of logic to handle window decorations, client,
>> > > background, main menu, etc... All windows now have a frame object.
>> > >
>> > > I have also bumped the theme version from 110 to 119 but this does not
>> > > mean a theme >= 119 is required. 110 is still supported of course. I
>> have
>> > > added a few fallback mechanisms to handle legacy themes, but this
>> > increases
>> > > code complexity a bit :(
>> > >
>> > >
>> > >
>> > > New features:
>> > > - Experimental CSD for X11 (client-side decorations).
>> > > - Stacked box class.
>> > > - Menu & background are swallowed in the frame. This will allow us to
>> > move
>> > > them or other widgets (eg. tabs) inside the title bar directl.
>> > > - efl_part(win, "background") can be used to set a color, file or
>> object
>> > > as background
>> > > - efl_part(win, "content") is the only slot to be used for a window
>> > > content (no more elm_win_resize_object in EO APIs)
>> > >
>> > >
>> > >
>> > > How to test CSD on X:
>> > > - export EFL_WIN_FRAME_MODE=on
>> > >
>> > > Things not working yet:
>> > > - CSD mode/resize in some X window managers (E works)
>> > > - No system menu (icon click / title bar right click). GTK3
>> implements a
>> > > custom menu, there doesn't seem to be any existing X protocol to popup
>> > the
>> > > window manager's window menu.
>> > > - Sticky, etc... are thus all lost unless you use a special key to
>> open
>> > > the window manager's window menu
>> > >
>> > >
>> > >
>> > > Final note:
>> > > Please report any issues, especially with non-default themes!
>> > >
>> > >
>> > > Thanks in advance!
>> > >
>> > > --
>> > > Jean-Philippe André
>> > >
>> > >
>> >
>> >
>> > --
>> > Jean-Philippe André
>> >
>> > ------------------------------------------------------------
>> ------------------
>> > _______________________________________________
>> > enlightenment-devel mailing list
>> > enlightenment-devel@lists.sourceforge.net
>> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>> >
>> ------------------------------------------------------------
>> ------------------
>> _______________________________________________
>> enlightenment-devel mailing list
>> enlightenment-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>>
>
>
>
> --
> Jean-Philippe André
>
--
Jean-Philippe André
------------------------------------------------------------------------------
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
