Hello. On 27/11/16 11:32, Carsten Haitzler wrote: > raster pushed a commit to branch master. > > http://git.enlightenment.org/core/efl.git/commit/?id=bba368cf79acb5221d108cd257701523bd50ae2a > > commit bba368cf79acb5221d108cd257701523bd50ae2a > Author: Carsten Haitzler (Rasterman) <[email protected]> > Date: Sun Nov 27 12:05:26 2016 +0900 > > evas render - evas_object_clip_recalc - dont call uselessly > > evas_object_clip_recalc was already called ... multiple times in > pending and phase1 on all objects, so there is no value in calling it > again and again in later evbas render phases when it's already been > done. > > this and moving this to a real func sees evas_object_clip_recalc usage > in perf drop from 1.8% to 1.4% or so of total perf sample time. tiny > win, but we're at the point where i can't find big meaty wins, so i'm > looking for a string of small wins to add up. > > @optimize
This change breaks the evas test suite. Bisecting brought me here and reverting this commit does indeed let the test suite run through again. Failing test case: tests/evas/evas_test_mask.c:223:F:Masking:evas_mask_test_compare_clip:0: Failure '_bgra_compare(data, refdata[1], W, H)' occurred I see this here locally as well as on Jenkins. regards Stefan Schmidt ------------------------------------------------------------------------------ _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
