Hello.
On 30/11/16 10:22, Amitesh Singh wrote:
> jpeg pushed a commit to branch master.
>
> http://git.enlightenment.org/core/efl.git/commit/?id=a58e2e1a790732428fa09d479fec63d433931f06
>
> commit a58e2e1a790732428fa09d479fec63d433931f06
> Author: Amitesh Singh <[email protected]>
> Date: Wed Nov 30 16:18:46 2016 +0900
>
> Menu,Item Interface: Common interface for menu, toolbar and ctxpopup
>
> Summary:
> efl_ui_menu interface provides common functions of menu, toolbar and
> ctxpopup.
> efl_ui_item interface provides common functions of menu_item,
> toolbar_item and ctxpopup_item.
> Also implemented some missing functions like selected_item set/get in
> ctxpopup.
> efl_ui_item interface should be used for other widget items as well.
>
> Test Plan: elementary_test
>
> Reviewers: jpeg, felipealmeida, raster, SanghyeonLee, cedric, yashu21985
>
> Subscribers: bu5hm4n
>
> Differential Revision: https://phab.enlightenment.org/D3897
> ---
> src/Makefile_Efl.am | 2 +
> src/bin/elementary/test_ctxpopup.c | 9 ++-
> src/lib/efl/Efl.h | 2 +
> src/lib/efl/interfaces/efl_interfaces_main.c | 2 +
> src/lib/efl/interfaces/efl_ui_item.eo | 49 ++++++++++++
> src/lib/efl/interfaces/efl_ui_menu.eo | 29 +++++++
> src/lib/elementary/elc_ctxpopup.c | 109
> +++++++++++++++++++++++++--
> src/lib/elementary/elc_ctxpopup_legacy.h | 77 +++++++++++++++++++
> src/lib/elementary/elm_ctxpopup.eo | 58 ++------------
> src/lib/elementary/elm_ctxpopup_item.eo | 33 +-------
> src/lib/elementary/elm_dbus_menu.c | 4 +-
> src/lib/elementary/elm_menu.c | 78 ++++++++++++++++---
> src/lib/elementary/elm_menu.eo | 31 ++------
> src/lib/elementary/elm_menu_item.eo | 25 ++----
> src/lib/elementary/elm_menu_legacy.h | 57 ++++++++++++++
> src/lib/elementary/elm_toolbar.c | 64 ++++++++++++++--
> src/lib/elementary/elm_toolbar.eo | 35 ++-------
> src/lib/elementary/elm_toolbar_item.eo | 50 +-----------
> src/lib/elementary/elm_toolbar_legacy.h | 86 +++++++++++++++++++++
> src/lib/elementary/elm_widget_ctxpopup.h | 2 +
> 20 files changed, 570 insertions(+), 232 deletions(-)
This commit brought two new warnings into the build. Both look serious
to be taken into account. :)
lib/elementary/elm_dbus_menu.c: In function ‘_root_layout_build’:
lib/elementary/elm_dbus_menu.c:364:13: warning: assignment from
incompatible pointer type [-Wincompatible-pointer-types]
ret = efl_ui_menu_items_get(dbus_menu->menu);
lib/elementary/elm_toolbar.c: In function
‘_elm_toolbar_efl_ui_menu_items_get’:
lib/elementary/elm_toolbar.c:3257:34: warning: passing argument 1 of
‘eina_list_iterator_new’ from incompatible pointer type
[-Wincompatible-pointer-types]
return eina_list_iterator_new(sd->items);
^
In file included from ../src/lib/eina/Eina.h:223:0,
from ../src/lib/elementary/Elementary.h:57,
from lib/elementary/elm_toolbar.c:10:
../src/lib/eina/eina_list.h:1302:56: note: expected ‘const Eina_List *
{aka const struct _Eina_List *}’ but argument is of type ‘Eina_Inlist *
{aka struct _Eina_Inlist *}’
EAPI Eina_Iterator *eina_list_iterator_new(const Eina_List
*list) EINA_MALLOC EINA_WARN_UNUSED_RESULT;
regards
Stefan Schmidt
------------------------------------------------------------------------------
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
