stefan pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=e90622ec41460165192b98ec2fe1aacda61937bc
commit e90622ec41460165192b98ec2fe1aacda61937bc
Author: Stefan Schmidt <ste...@osg.samsung.com>
Date: Tue Dec 6 14:33:24 2016 +0100
all: use void if we really want to make sure we do not accept parameters
In C we need this to make clear that we really do not accept parameters.
Found by the smatch source code matcher. I had run and fixed this before
but it seems to creep in again over time.
---
src/lib/efl/interfaces/efl_model_common.c | 2 +-
src/lib/eina/eina_debug_monitor.c | 2 +-
src/lib/eo/eo_add_fallback.c | 2 +-
src/lib/evas/canvas/evas_canvas3d_eet.c | 6 +++---
src/lib/evas/canvas/evas_gl.c | 2 +-
src/lib/evas/common3d/save_load/evas_model_load_save_common.c | 2 +-
src/lib/evas/cserve2/evas_cs2_client.c | 4 ++--
src/lib/evas/filters/evas_filter.c | 4 ++--
src/lib/evas/main.c | 2 +-
src/modules/evas/model_loaders/obj/evas_model_load_obj.c | 2 +-
src/static_libs/draw/draw_main.c | 2 +-
src/static_libs/draw/draw_main_neon.c | 2 +-
12 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/src/lib/efl/interfaces/efl_model_common.c
b/src/lib/efl/interfaces/efl_model_common.c
index 3b32205..afe6a04 100644
--- a/src/lib/efl/interfaces/efl_model_common.c
+++ b/src/lib/efl/interfaces/efl_model_common.c
@@ -22,7 +22,7 @@ static const char EFL_MODEL_ERROR_PERMISSION_DENIED_STR[] =
"Permission denied";
static const char EFL_MODEL_ERROR_INCORRECT_VALUE_STR[] = "Incorrect value";
EAPI int
-efl_model_init()
+efl_model_init(void)
{
EFL_MODEL_ERROR_INCORRECT_VALUE = eina_error_msg_static_register(
EFL_MODEL_ERROR_INCORRECT_VALUE_STR);
diff --git a/src/lib/eina/eina_debug_monitor.c
b/src/lib/eina/eina_debug_monitor.c
index ed65a34..06e939b 100644
--- a/src/lib/eina/eina_debug_monitor.c
+++ b/src/lib/eina/eina_debug_monitor.c
@@ -648,7 +648,7 @@ _eina_debug_monitor_signal_init(void)
}
static const char *
-_socket_home_get()
+_socket_home_get(void)
{
// get possible debug daemon socket directory base
const char *dir = getenv("XDG_RUNTIME_DIR");
diff --git a/src/lib/eo/eo_add_fallback.c b/src/lib/eo/eo_add_fallback.c
index e00d7e8..c38a827 100644
--- a/src/lib/eo/eo_add_fallback.c
+++ b/src/lib/eo/eo_add_fallback.c
@@ -64,7 +64,7 @@ _eo_call_stack_mem_free(void *ptr, size_t size)
}
static Efl_Object_Call_Stack *
-_eo_call_stack_create()
+_eo_call_stack_create(void)
{
Efl_Object_Call_Stack *stack;
diff --git a/src/lib/evas/canvas/evas_canvas3d_eet.c
b/src/lib/evas/canvas/evas_canvas3d_eet.c
index 0c43e06..ca24450 100644
--- a/src/lib/evas/canvas/evas_canvas3d_eet.c
+++ b/src/lib/evas/canvas/evas_canvas3d_eet.c
@@ -27,7 +27,7 @@ _evas_canvas3d_eet_file_new(void)
}
Eet_Data_Descriptor*
-_evas_canvas3d_eet_file_get()
+_evas_canvas3d_eet_file_get(void)
{
if(_file_descriptor == NULL)
_evas_canvas3d_eet_file_init();
@@ -35,7 +35,7 @@ _evas_canvas3d_eet_file_get()
return _file_descriptor;
}
void
-_evas_canvas3d_eet_file_init()
+_evas_canvas3d_eet_file_init(void)
{
/* initialization of bonding between structure units in eet file */
Eet_Data_Descriptor_Class eddc;
@@ -158,7 +158,7 @@ _evas_canvas3d_eet_file_init()
}
void
-_evas_canvas3d_eet_descriptor_shutdown()
+_evas_canvas3d_eet_descriptor_shutdown(void)
{
eet_data_descriptor_free(_geometry_descriptor);
_geometry_descriptor = NULL;
diff --git a/src/lib/evas/canvas/evas_gl.c b/src/lib/evas/canvas/evas_gl.c
index 5a71f12..0f4760c 100644
--- a/src/lib/evas/canvas/evas_gl.c
+++ b/src/lib/evas/canvas/evas_gl.c
@@ -196,7 +196,7 @@ evas_gl_free(Evas_GL *evas_gl)
}
EAPI Evas_GL_Config *
-evas_gl_config_new()
+evas_gl_config_new(void)
{
Evas_GL_Config *cfg;
diff --git a/src/lib/evas/common3d/save_load/evas_model_load_save_common.c
b/src/lib/evas/common3d/save_load/evas_model_load_save_common.c
index 8c12914..925793b 100644
--- a/src/lib/evas/common3d/save_load/evas_model_load_save_common.c
+++ b/src/lib/evas/common3d/save_load/evas_model_load_save_common.c
@@ -26,7 +26,7 @@
/* create new header */
Evas_Model_Load_Save_Header
-evas_model_load_save_header_new()
+evas_model_load_save_header_new(void)
{
Evas_Model_Load_Save_Header header;
diff --git a/src/lib/evas/cserve2/evas_cs2_client.c
b/src/lib/evas/cserve2/evas_cs2_client.c
index 62f0bfe..626d79e 100644
--- a/src/lib/evas/cserve2/evas_cs2_client.c
+++ b/src/lib/evas/cserve2/evas_cs2_client.c
@@ -306,7 +306,7 @@ _shared_index_close(Shared_Index *si)
}
static void
-_shared_index_close_all()
+_shared_index_close_all(void)
{
DBG("Closing all index files");
if (_index.strings_entries.f)
@@ -325,7 +325,7 @@ _shared_index_close_all()
}
static Eina_Bool
-_server_reconnect()
+_server_reconnect(void)
{
_shared_index_close_all();
diff --git a/src/lib/evas/filters/evas_filter.c
b/src/lib/evas/filters/evas_filter.c
index 8c9bdc8..63ab6a3 100644
--- a/src/lib/evas/filters/evas_filter.c
+++ b/src/lib/evas/filters/evas_filter.c
@@ -1622,14 +1622,14 @@ static int init_cnt = 0;
int _evas_filter_log_dom = 0;
void
-evas_filter_init()
+evas_filter_init(void)
{
if ((init_cnt++) > 0) return;
_evas_filter_log_dom = eina_log_domain_register("evas_filter",
EVAS_FILTER_LOG_COLOR);
}
void
-evas_filter_shutdown()
+evas_filter_shutdown(void)
{
if ((--init_cnt) > 0) return;
evas_filter_parser_shutdown();
diff --git a/src/lib/evas/main.c b/src/lib/evas/main.c
index e59877c..8c31d8e 100644
--- a/src/lib/evas/main.c
+++ b/src/lib/evas/main.c
@@ -50,7 +50,7 @@ evas_mem_calloc(int size)
}
static void
-_evas_debug_init_from_env()
+_evas_debug_init_from_env(void)
{
const char *tmp = getenv("EVAS_DEBUG_SHOW");
if (tmp)
diff --git a/src/modules/evas/model_loaders/obj/evas_model_load_obj.c
b/src/modules/evas/model_loaders/obj/evas_model_load_obj.c
index 3ec4ed5..2b18c61 100644
--- a/src/modules/evas/model_loaders/obj/evas_model_load_obj.c
+++ b/src/modules/evas/model_loaders/obj/evas_model_load_obj.c
@@ -48,7 +48,7 @@ struct _OBJ_Counts
/* create new counter */
static inline OBJ_Counts
-_new_count_elements()
+_new_count_elements(void)
{
OBJ_Counts counts;
diff --git a/src/static_libs/draw/draw_main.c b/src/static_libs/draw/draw_main.c
index 3d92063..40b32e9 100644
--- a/src/static_libs/draw/draw_main.c
+++ b/src/static_libs/draw/draw_main.c
@@ -278,7 +278,7 @@ efl_draw_func_span_get(Efl_Gfx_Render_Op op, uint32_t
color, Eina_Bool src_alpha
}
int
-efl_draw_init()
+efl_draw_init(void)
{
static int i = 0;
if (!(i++))
diff --git a/src/static_libs/draw/draw_main_neon.c
b/src/static_libs/draw/draw_main_neon.c
index 0441147..24b3d01 100644
--- a/src/static_libs/draw/draw_main_neon.c
+++ b/src/static_libs/draw/draw_main_neon.c
@@ -214,7 +214,7 @@ comp_func_source_over_sse2(uint32_t * __restrict dest,
const uint32_t * __restri
#endif
void
-efl_draw_neon_init()
+efl_draw_neon_init(void)
{
#ifdef BUILD_NEON
if (eina_cpu_features_get() & EINA_CPU_NEON)
--
