As mentioned on irc... using ec->visible won't work because ec->visible is true before the actual frame is drawn thus the preview shown will be a mirror of nothing.
On Wed, Dec 14, 2016 at 10:33 AM Mike Blumenkrantz < [email protected]> wrote: > This should probably check ec->visible since the check here would fail for > minimized windows and windows on hidden desktops. > > On Wed, Dec 14, 2016 at 11:24 AM Stephen 'Okra' Houston < > [email protected]> wrote: > > > okra pushed a commit to branch master. > > > > > > > http://git.enlightenment.org/core/enlightenment.git/commit/?id=d7f22721a203c42db98465af328aec334248d39e > > > > commit d7f22721a203c42db98465af328aec334248d39e > > Author: Stephen 'Okra' Houston <[email protected]> > > Date: Wed Dec 14 10:23:25 2016 -0600 > > > > Luncher: Add preview windows to the popup on exec if they are already > > visible. > > --- > > src/modules/luncher/bar.c | 14 ++++++++++---- > > 1 file changed, 10 insertions(+), 4 deletions(-) > > > > diff --git a/src/modules/luncher/bar.c b/src/modules/luncher/bar.c > > index eb47f07..27751bd 100644 > > --- a/src/modules/luncher/bar.c > > +++ b/src/modules/luncher/bar.c > > @@ -1298,15 +1298,21 @@ _bar_cb_exec_new(void *data EINA_UNUSED, int > type, > > E_Exec_Instance *ex) > > { > > if (!eina_list_data_find(ic->execs, ex)) > > ic->execs = eina_list_append(ic->execs, ex); > > - evas_object_event_callback_add(ec->frame, > > EVAS_CALLBACK_SHOW, > > - _bar_exec_new_show, ic); > > + if (evas_object_visible_get(ec->frame)) > > + _bar_exec_new_show(ic, NULL, NULL, NULL); > > + else > > + evas_object_event_callback_add(ec->frame, > > EVAS_CALLBACK_SHOW, > > + _bar_exec_new_show, ic); > > } > > else > > { > > if (!eina_list_data_find(ic->clients, ec)) > > ic->clients = eina_list_append(ic->clients, ec); > > - evas_object_event_callback_add(ec->frame, > > EVAS_CALLBACK_SHOW, > > - _bar_exec_new_show, ic); > > + if (evas_object_visible_get(ec->frame)) > > + _bar_exec_new_show(ic, NULL, NULL, NULL); > > + else > > + evas_object_event_callback_add(ec->frame, > > EVAS_CALLBACK_SHOW, > > + _bar_exec_new_show, ic); > > } > > } > > else > > > > -- > > > > > > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, SlashDot.org! http://sdm.link/slashdot > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
