Hello. On 20/12/16 20:21, Felipe Magno de Almeida wrote: > On Fri, Dec 16, 2016 at 7:08 AM, Stefan Schmidt <ste...@osg.samsung.com> > wrote: >> Hello. >> >> On 22/11/16 17:38, Stefan Schmidt wrote: >>> >>> >>> CXX: (Felipe could you have a look?) >>> 1361235 Big parameter passed by value >>> 1361234 Big parameter passed by value >>> 1361233 Big parameter passed by value >>> 1361232 Big parameter passed by value >>> 1361231 Big parameter passed by value >>> 1361230 Big parameter passed by value >>> 1361229 Big parameter passed by value >>> 1361228 Big parameter passed by value >>> 1361227 Big parameter passed by value >>> 1361226 Big parameter passed by value >>> 1361225 Big parameter passed by value >> >> Felipe, > > Hello Stefan, > >> could you have a look at these bunch? From what I can see some of >> the parameters are as big as 460 bytes. Why would we need to pass them as a >> value? > > I've modified the ones that aren't necessary. Others are because they > can't guarantee the lifetime of the object, which is likely to be a > temporary. They could be passed as reference and then copied, but > that eliminates the RVO optimization, so it is actually better to > pass by-value. BTW, this code is only ran by the C++ generator, so > its efficiency is not really relevant too because it runs extremely fast > already and only runs when building. I also took care of of another > two CIDs related to eina-cxx.
Thanks for having a look at them and fixing the ones that could be fixed. regards Stefan Schmidt ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today.http://sdm.link/intel _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
