On Sat, 7 Jan 2017 21:42:32 +0300 Vasiliy Tolstov <v.tols...@selfip.ru> said:
> Sorry for my user pov, but why ci system allows to push to master breaking > stuff that does not compile? the problem is changes made to efl then break apps that depend on those changes so it's not within the same repo here... so a CI system wouldnt catch this unless it basically insists on building things outside a repo too. jenkins does run and it does report build failures to irc etc. ... but this is more a matter of "if you are changing api's like this ensure that code that depends on them now doesn't break"... or just dont push changes on a friday evening then go away for the weekend. :) > I'm package and use many software and most of them use pull request via > GitHub, gitlab,gogs,gerrit and other systems, and break master is very hard. it doesn't happen often to us either... the reason i am shouting now is... the people involved (they know who they are!) *SHOULD KNOW BETTER*! if it was a novice mistake - whatever. that's why we don't generally give commit access to novices or they are closely watched... but here they should know better. > 7 Янв 2017 г. 8:24 пользователь "Carsten Haitzler" <ras...@rasterman.com> > написал: > > > seriously. STOP IT. > > > > stop this git commit+push dump and run on a friday night... and then leave > > everything broken! saturday afternoon and i'm fixing basic build problems > > that > > should NOT HAPPEN. > > > > enlightenment doesn't build anymore! all these full-of-annoyance > > float/double > > compare shit stuff is broken! e can't build at all and everyone has run > > off for > > the night. > > > > come on guys. BASIC stuff. > > > > from now on. > > > > 1. you change api's in headers - you rebuild major sw against the new libs. > > don't push until you've done that. no pushing stuff on a friday night then > > disappearing to leave a mess. > > 2. did anyone PAY ATTENTION to all the BUGS that doing all of this "lets > > add a > > warning then shut it up by breaking code" have had to be fixed? more bugs > > than > > the warning ever pointed out and fixed. just ask jpeg. but yet we persist > > in > > blanketing code with these everywhere then leading to the above as then > > others > > change api's that were put everywhere. > > > > after all of the noise on this list it's still "jump all in and push stuff > > to > > silence the warning" ... i can only imagine what new bugs have now been > > introduced... > > > > -- > > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > > > > > ------------------------------------------------------------ > > ------------------ > > Check out the vibrant tech community on one of the world's most > > engaging tech sites, SlashDot.org! http://sdm.link/slashdot > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, SlashDot.org! http://sdm.link/slashdot > _______________________________________________ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
