devilhorns pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=f026055630da0265630163b82e68048fb6c03fed
commit f026055630da0265630163b82e68048fb6c03fed Author: Chris Michael <[email protected]> Date: Sun Jan 8 19:48:26 2017 -0500 evas-gl-common: Fix incorrect expression Coverity reports this as in incorrect expression because it was checking cache_entry width <= 0 twice. Fairly safe to assume that the proper check should be width || height. Fix CID1368336 Signed-off-by: Chris Michael <[email protected]> --- src/modules/evas/engines/gl_common/evas_gl_texture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/evas/engines/gl_common/evas_gl_texture.c b/src/modules/evas/engines/gl_common/evas_gl_texture.c index c6f045a..8400593 100644 --- a/src/modules/evas/engines/gl_common/evas_gl_texture.c +++ b/src/modules/evas/engines/gl_common/evas_gl_texture.c @@ -1174,7 +1174,7 @@ evas_gl_common_texture_upload(Evas_GL_Texture *tex, RGBA_Image *im, unsigned int GLuint fmt; if ((((int)im->cache_entry.w) <= 0) || - (((int)im->cache_entry.w) <= 0)) return; + (((int)im->cache_entry.h) <= 0)) return; fmt = tex->pt->format; glBindTexture(GL_TEXTURE_2D, tex->pt->texture); if (tex->gc->shared->info.unpack_row_length) --
