Instead of looking at ways to prove me wrong, perhaps it might be better to see what I've done and determine whether it fits the needs you have described.
If you want transparency and a blur filter, does what I've done prevent that? No, it does not. If you define the data.item in your theme, you can have transparency for as long as you want since I decided not to put a fixed timeout on show animations which would force opacity. If a theme wants to be translucent, it can do this. The only requirement is that the theme author has to knowingly decide to do this and then set a flag which informs the compositor that this is intentional and not by accident. "By default, however, this will be opaque" meant exactly what I said: desklocks will be opaque by default and then it is up to the theme designer to determine whether they need transparency. On Tue, Jan 10, 2017 at 6:36 PM Carsten Haitzler <ras...@rasterman.com> wrote: > On Tue, 10 Jan 2017 19:22:46 +0000 Mike Blumenkrantz > <michael.blumenkra...@gmail.com> said: > > > I already added functionality for this in the theme by setting > > 'show_signal' as a data.item when transparency is desired. By default, > > however, this will be opaque. > > your entire argument is invalid. If a theme wants to desklock by using > transparency and eg a huge blur filter - then WHY NOT? if your argument is > "well security" yet the theme can just never emit the show done signal ... > your > argument is invalid. > > if a theme wishes to be translucent - let it be. let users complain to the > theme author that it breaks their privacy. > > > I plan to revert this later in the week if you don't get to it before > then. > > > > On Sat, Jan 7, 2017 at 12:23 AM Carsten Haitzler <ras...@rasterman.com> > > wrote: > > > > > raster pushed a commit to branch master. > > > > > > > > > > http://git.enlightenment.org/core/enlightenment.git/commit/?id=0b0b6e6fd9b53e717037e404445716a67cbfe15e > > > > > > commit 0b0b6e6fd9b53e717037e404445716a67cbfe15e > > > Author: Carsten Haitzler (Rasterman) <ras...@rasterman.com> > > > Date: Sat Jan 7 14:19:18 2017 +0900 > > > > > > desklock - make blocker transparent again - a theme issue not code > > > > > > if "theme is transparent" and this is an issue - dont use that > theme. > > > very simple. the theme for a desk LOCK should be solid. it should > hide > > > what is underneath. that is the POINT is can have transition > effects > > > and that is why we shouldnt hide what is under it to allow that to > > > happen otherwise if you do have such an effect (eg a fade in) you > just > > > get a black screen instantly on ctrl+alt+l for lock for example > THEN > > > it fades in which is not how things SHOULD look. > > > > > > yes - there is an issue on locking on screen lock where you get an > > > initial fade in effect for example as desklock is shown LATER like > > > when screen "unsuspends" from blank rather thanbefore this point. > that > > > is orthogonal. this rect should block events... not pixels. don't > use > > > non-solid themes or images if you dont want to see through... > > > --- > > > src/bin/e_desklock.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/src/bin/e_desklock.c b/src/bin/e_desklock.c > > > index 8ec9234..664b921 100644 > > > --- a/src/bin/e_desklock.c > > > +++ b/src/bin/e_desklock.c > > > @@ -300,7 +300,7 @@ e_desklock_show(Eina_Bool suspend) > > > } > > > o = evas_object_rectangle_add(e_comp->evas); > > > block_rects[zone->num] = o; > > > - evas_object_color_set(o, 0, 0, 0, 255); > > > + evas_object_color_set(o, 0, 0, 0, 0); > > > evas_object_geometry_set(o, zone->x, zone->y, zone->w, > zone->h); > > > evas_object_layer_set(o, E_LAYER_DESKLOCK); > > > if (!block_zone[zone->num]) > > > > > > -- > > > > > > > > > > > > ------------------------------------------------------------------------------ > > Developer Access Program for Intel Xeon Phi Processors > > Access to Intel Xeon Phi processor-based developer platforms. > > With one year of Intel Parallel Studio XE. > > Training and support from Colfax. > > Order your platform today. http://sdm.link/xeonphi > > _______________________________________________ > > enlightenment-devel mailing list > > enlightenment-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > -- > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
