[EGIT] [tools/eflete] eflete-1.18 66/91: popup: fix NULL pointer deref

[Andrii Kroitor]

rimmed pushed a commit to branch eflete-1.18.

http://git.enlightenment.org/tools/eflete.git/commit/?id=919267bf832a928c632308c9759120536fee84b9

commit 919267bf832a928c632308c9759120536fee84b9
Author: Andrii Kroitor <an.kroi...@samsung.com>
Date:   Thu Sep 15 12:33:09 2016 +0300

    popup: fix NULL pointer deref
    
    Fix svace WID 436496
---
 src/bin/ui/popup.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/bin/ui/popup.c b/src/bin/ui/popup.c
index 7d262a4..3fd42bf 100644
--- a/src/bin/ui/popup.c
+++ b/src/bin/ui/popup.c
@@ -317,6 +317,9 @@ _helper_colorclass_dismiss(void *data,
                            const char *source __UNUSED__)
 {
    Helper_Data *helper_data = (Helper_Data *)data;
+
+   assert(helper_data != NULL);
+
    Evas_Object *follow_up = helper_data->follow_up;
 
    evas_object_event_callback_del_full(follow_up, EVAS_CALLBACK_RESIZE, 
_helper_obj_follow, NULL);
@@ -338,7 +341,7 @@ _helper_colorclass_dismiss(void *data,
    if (helper_data->button)
      evas_object_del(helper_data->button);
 
-   if (helper_data) free(helper_data);
+   free(helper_data);
 
    ecore_job_add(_delete_object_job, helper);
 }

--