devilhorns pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=f1c9088c14f2527fd9040c7b48f88d2597aeab10
commit f1c9088c14f2527fd9040c7b48f88d2597aeab10 Author: Chris Michael <[email protected]> Date: Wed Jan 25 08:56:38 2017 -0500 ethumb: Fix resource leak Coverity reports a resource leak here as we were not freeing 'sanitized_path' inside the if statement. Fixes CID1367502 @fix Signed-off-by: Chris Michael <[email protected]> --- src/lib/ethumb/ethumb.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/lib/ethumb/ethumb.c b/src/lib/ethumb/ethumb.c index ef18564..73ec5b9 100644 --- a/src/lib/ethumb/ethumb.c +++ b/src/lib/ethumb/ethumb.c @@ -844,7 +844,11 @@ ethumb_file_set(Ethumb *e, const char *path, const char *key) sanitized_path = eina_file_path_sanitize(path); DBG("ethumb=%p, path=%s, key=%s", e, sanitized_path ? sanitized_path : "", key ? key : ""); - if (sanitized_path && access(sanitized_path, R_OK)) return EINA_FALSE; + if (sanitized_path && access(sanitized_path, R_OK)) + { + free(sanitized_path); + return EINA_FALSE; + } eina_stringshare_replace(&e->src_hash, NULL); eina_stringshare_replace(&e->src_path, sanitized_path); --
