Nice catch!

On Sat, Jan 28, 2017 at 5:03 PM Marcel Hollerbach <
[email protected]> wrote:

> bu5hm4n pushed a commit to branch master.
>
>
> http://git.enlightenment.org/core/enlightenment.git/commit/?id=738f6d8f6b9994e6d6cdc5aad706d11223f31a91
>
> commit 738f6d8f6b9994e6d6cdc5aad706d11223f31a91
> Author: Marcel Hollerbach <[email protected]>
> Date:   Sat Jan 28 23:00:10 2017 +0100
>
>     e_gadget: fix destroying of drop_objects
>
>     keys of pointer hashes are represent as void** so you just get a
> pointer
>     to where the pointer can be found. This now dereferences the pointer so
>     the correct value is used.
>
>     This fixes T5136.
> ---
>  src/bin/e_gadget.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/src/bin/e_gadget.c b/src/bin/e_gadget.c
> index c24fbf0..34d1337 100644
> --- a/src/bin/e_gadget.c
> +++ b/src/bin/e_gadget.c
> @@ -300,14 +300,14 @@ _gadget_object_free(E_Object *eobj)
>
>     if (zgc->drop_handlers)
>       {
> -        Evas_Object *drop_object;
> +        Evas_Object **drop_object;
>          Eina_Iterator *it =
> eina_hash_iterator_key_new(zgc->drop_handlers);
>
>          EINA_ITERATOR_FOREACH(it, drop_object)
>            {
> -             evas_object_event_callback_del(drop_object,
> EVAS_CALLBACK_MOVE, _gadget_drop_handler_moveresize);
> -             evas_object_event_callback_del(drop_object,
> EVAS_CALLBACK_RESIZE, _gadget_drop_handler_moveresize);
> -             evas_object_event_callback_del(drop_object,
> EVAS_CALLBACK_DEL, _gadget_drop_handler_del);
> +             evas_object_event_callback_del(*drop_object,
> EVAS_CALLBACK_MOVE, _gadget_drop_handler_moveresize);
> +             evas_object_event_callback_del(*drop_object,
> EVAS_CALLBACK_RESIZE, _gadget_drop_handler_moveresize);
> +             evas_object_event_callback_del(*drop_object,
> EVAS_CALLBACK_DEL, _gadget_drop_handler_del);
>            }
>          eina_iterator_free(it);
>       }
>
> --
>
>
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
enlightenment-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

Reply via email to