On Tue, Feb 07, 2017 at 11:03:05AM -0200, Gustavo Sverzut Barbieri wrote:
> > diff --git a/cmake/config/ecore_x.cmake b/cmake/config/ecore_x.cmake
> > new file mode 100644
> > index 0000000..e95e6b2
> > --- /dev/null
> > +++ b/cmake/config/ecore_x.cmake
> > @@ -0,0 +1,110 @@
> > +include(FindX11)
> > +
> > +EFL_OPTION(XGESTURE "Whenever you want ecore_x to use gesture" OFF)
> > +EFL_OPTION(XPRESENT "Whenever you want ecore_x to use xpresent" OFF)
> > +EFL_OPTION(XINPUT2 "Whenever you want ecore_x to use xinput2" ON)
> > +EFL_OPTION(XINPUT22 "Whenever you want ecore_x to use xinput22" OFF)
> > +
> > +#the rest is just statically enabled
> > +CHECK_APPEND_DEFINE(HAVE_ECORE_X_XLIB ON)
> > +CHECK_APPEND_DEFINE(ECORE_XKB ON)
> > +CHECK_APPEND_DEFINE(ECORE_XCOMPOSITE ON)
> > +CHECK_APPEND_DEFINE(ECORE_XDAMAGE ON)
> > +CHECK_APPEND_DEFINE(ECORE_XDPMS ON)
> > +CHECK_APPEND_DEFINE(ECORE_XFIXES ON)
> > +CHECK_APPEND_DEFINE(ECORE_XINERAMA ON)
> > +CHECK_APPEND_DEFINE(ECORE_XRANDR ON)
> > +CHECK_APPEND_DEFINE(ECORE_XSS ON)
> > +CHECK_APPEND_DEFINE(ECORE_XTEST ON)
> > +
> > +#FindX11 does not cover all parts we need so here are the 4 extensions we
> > need to check
> > +
> > +#copied from
> > https://github.com/Kitware/CMake/blob/master/Modules/FindX11.cmake#L65
> > +set(X11_INC_SEARCH_PATH
> > + /usr/pkg/xorg/include
> > + /usr/X11R6/include
> > + /usr/X11R7/include
> > + /usr/include/X11
> > + /usr/openwin/include
> > + /usr/openwin/share/include
> > + /opt/graphics/OpenGL/include
> > + /opt/X11/include
> > +)
> > +
> > +set(X11_LIB_SEARCH_PATH
> > + /usr/pkg/xorg/lib
> > + /usr/X11R6/lib
> > + /usr/X11R7/lib
> > + /usr/openwin/lib
> > + /opt/X11/lib
> > +)
>
> why do you need to redeclare these? Can't you simply use the variables
> defined in FindX11? I didn't check, but maybe you can access that
> after FindX11 is used.
The reason i copied it is that the lists are not part of the
documentation, i can use the one defined in FindX11.cmake but when they
are getting removed / renamed we need to declare them again. I am not so
sure if we should rely on them here.
>
> > +if (${XGESTURE})
>
> usually it's if(XGESTURE), not ${}... I believe the reason is
> if(${EMPTY_VAR}) will cause an error, while if(EMPTY_VAR) will work,
> not sure, but that's the standard.
>
XGESTURE is a option, which is always defined as ON or OFF and i want to
check here if its ON or OFF. So i think thats fine.
>
> > +configure_file(
> > + ${PROJECT_SOURCE_DIR}/src/lib/ecore_x/ecore_x_version.h.cmake
> > + ${PROJECT_BINARY_DIR}/src/lib/ecore_x/ecore_x_version.h)
>
> prefer to use the CHECK_INIT(ecore_x) and then call for a finalize on
> the file you want.
Thats a left over and will be removed.
>
> > diff --git a/src/lib/ecore_x/CMakeLists.txt b/src/lib/ecore_x/CMakeLists.txt
> > new file mode 100644
> > index 0000000..fec2eae
> > --- /dev/null
> > +++ b/src/lib/ecore_x/CMakeLists.txt
> > @@ -0,0 +1,61 @@
> > +set(PUBLIC_LIBRARIES
> > + eina
> > + ecore
> > +)
>
> let's try to keep these sorted, it's easier to insert and search later.
>
>
> > +message("${LIBRARIES}")
>
> left over? Or at least add some prefix/meaningful message what's this about.
>
Its a left over...
>
> > +
> > +#todo XRANDR_GOOD
> > +
> > +set(PUBLIC_HEADERS
> > + Ecore_X.h
> > + # ecore_x_version.h
> > + Ecore_X_Atoms.h
> > + Ecore_X_Cursor.h
> > +)
> > +
> > +set(SOURCES
> > + ecore_x_atoms_decl.h
> > + ecore_x.c
> > + ecore_x_dnd.c
> > + ecore_x_sync.c
> > + ecore_x_randr.c
> > + ecore_x_fixes.c
> > + ecore_x_damage.c
> > + ecore_x_composite.c
> > + ecore_x_error.c
> > + ecore_x_events.c
> > + ecore_x_icccm.c
> > + ecore_x_keygrab.c
> > + ecore_x_netwm.c
> > + ecore_x_mwm.c
> > + ecore_x_e.c
> > + ecore_x_selection.c
> > + ecore_x_window.c
> > + ecore_x_window_prop.c
> > + ecore_x_window_shape.c
> > + ecore_x_pixmap.c
> > + ecore_x_present.c
> > + ecore_x_gc.c
> > + ecore_x_xinerama.c
> > + ecore_x_screensaver.c
> > + ecore_x_dpms.c
> > + ecore_x_drawable.c
> > + ecore_x_cursor.c
> > + ecore_x_test.c
> > + ecore_x_atoms.c
> > + ecore_x_region.c
> > + ecore_x_image.c
> > + ecore_x_xi2.c
> > + ecore_x_vsync.c
> > + ecore_x_gesture.c
> > + ecore_x_private.h
> > +)
>
> sort as well, plz
>
> >
> > --
> >
> >
>
>
>
> --
> Gustavo Sverzut Barbieri
> --------------------------------------
> Mobile: +55 (16) 99354-9890
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
