On Thu, 09 Feb 2017 15:27:57 +0000 Mike Blumenkrantz <[email protected]> said:
> Please. I'm literally begging everyone at this point. Please stop pushing > patches to Wayland things without testing. We do not have the manpower to > continue active development while spending this much time tracking > regressions. i tested. it worked for me. deal with it. i guess i got lucky and my stack had NULL there and thus free didnt barf. do you want me to pull you up on every commit you do that introduces a bug and just claim you never tested it and should stop committing things? it'll be a long list if i'd been doing this over the years... > On Thu, Feb 9, 2017 at 10:18 AM Derek Foreman <[email protected]> > wrote: > > > derekf pushed a commit to branch master. > > > > > > http://git.enlightenment.org/core/efl.git/commit/?id=2800038ee212de4588471bca5d0773599b93d470 > > > > commit 2800038ee212de4588471bca5d0773599b93d470 > > Author: Derek Foreman <[email protected]> > > Date: Thu Feb 9 08:58:03 2017 -0600 > > > > Revert "vpath usage - simplify to bare minimum to make gustavo happy" > > > > This reverts commit 2037474dc0fd2b360452f2a15abcbe533b57ca37. > > > > This causes the wayland_shm engine to seg fault immediately at > > startup when attempting to create shm buffers. > > > > Please make sure when committing changes to the wayland_shm engine to > > test on intel, exynos, and at least one platform without dmabuf > > capabilities - or using the EVAS_WAYLAND_SHM_DISABLE_DMABUF env var > > to disable dmabuf on intel or exynos. > > > > Anyone without the time or hardware to fully test changes to > > wayland_shm > > can submit a patch to phabricator and assign it to me so I can fully > > test it before landing. > > --- > > src/lib/efreet/efreet_base.c | 5 +++-- > > src/lib/elementary/elm_config.c | 28 > > ++++++++++++++++++------- > > src/lib/elput/elput_evdev.c | 11 +++++++--- > > src/modules/ecore_buffer/shm/ecore_buffer_shm.c | 15 +++++++++---- > > src/modules/evas/engines/wayland_shm/evas_shm.c | 16 +++++++++----- > > 5 files changed, 54 insertions(+), 21 deletions(-) > > > > > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, SlashDot.org! http://sdm.link/slashdot > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
