raster pushed a commit to branch master.

http://git.enlightenment.org/core/enlightenment.git/commit/?id=39752e55ec6b90a3c945f08dbde637d778a05500

commit 39752e55ec6b90a3c945f08dbde637d778a05500
Author: Carsten Haitzler (Rasterman) <[email protected]>
Date:   Sun Feb 12 13:56:36 2017 +0900

    e fileman config - fix definite alignment bug with cast char to int ptr
    
    we're casting ptrs to char fields to int * which is actually wrong as
    we break alignment guarantees. fix.
---
 src/modules/fileman/e_mod_config.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/modules/fileman/e_mod_config.c 
b/src/modules/fileman/e_mod_config.c
index 9c78343..6320620 100644
--- a/src/modules/fileman/e_mod_config.c
+++ b/src/modules/fileman/e_mod_config.c
@@ -6,7 +6,7 @@ struct _E_Config_Dialog_Data
    /* general view mode */
     struct
     {
-       E_Fm2_View_Mode mode;
+       int mode;
        int open_dirs_in_place;
        int selector;
        int single_click;
@@ -27,8 +27,8 @@ struct _E_Config_Dialog_Data
    {
       double delay;
       double size;
-      Eina_Bool enable;
-      Eina_Bool clamp_size;
+      int enable;
+      int clamp_size;
       Evas_Object *check_clamp_size;
       Evas_Object *delay_slider_text;
       Evas_Object *delay_slider;
@@ -234,7 +234,7 @@ _basic_check_changed(E_Config_Dialog *cfd  EINA_UNUSED,
                      E_Config_Dialog_Data *cfdata)
 {
    return
-     (fileman_config->view.mode != cfdata->view.mode) ||
+     ((int)fileman_config->view.mode != cfdata->view.mode) ||
      (fileman_config->view.open_dirs_in_place != 
cfdata->view.open_dirs_in_place) ||
      (fileman_config->view.single_click != cfdata->view.single_click) ||
      (e_config->filemanager_copy != cfdata->copy) ||
@@ -310,7 +310,7 @@ _basic_create(E_Config_Dialog *cfd  EINA_UNUSED,
 
    o = e_widget_list_add(evas, 0, 0);
    of = e_widget_framelist_add(evas, _("View Mode"), 0);
-   rg = e_widget_radio_group_new((int*)&(cfdata->view.mode));
+   rg = e_widget_radio_group_new(&cfdata->view.mode);
 /*    ob = e_widget_radio_add(evas, _("Icons"), 0, rg); */
 /*    e_widget_disabled_set(ob, 1); */
 /*    e_widget_framelist_object_append(of, ob); */
@@ -464,11 +464,11 @@ _basic_create(E_Config_Dialog *cfd  EINA_UNUSED,
    /////////////////////////////////////////////////////////////
    o = e_widget_list_add(evas, 1, 0);
    ob = e_widget_check_add(evas, _("Show tooltip"),
-                           (int*)&(cfdata->tooltip.enable));
+                           &cfdata->tooltip.enable);
    e_widget_on_change_hook_set(ob, _tooltip_changed, cfdata);
    e_widget_list_object_append(o, ob, 1, 1, 0.5);
    cfdata->tooltip.check_clamp_size = ob = e_widget_check_add(evas, _("Clamp 
video size"),
-                           (int*)&(cfdata->tooltip.clamp_size));
+                           &cfdata->tooltip.clamp_size);
    e_widget_list_object_append(o, ob, 1, 1, 0.5);
    cfdata->tooltip.delay_slider_text = ob = e_widget_label_add(evas, 
_("Tooltip delay"));
    e_widget_list_object_append(o, ob, 1, 1, 0.5);

-- 


Reply via email to