On Mon, 20 Feb 2017 15:00:10 +0000 Mike Blumenkrantz <michael.blumenkra...@gmail.com> said:
> Technically the defines used in this commit indicate the requirement for a > released version of EFL, whereas this code only requires a git checkout-- > EFL_VERSION_$MAJ_$MIN indicates the latter. Had there been no pre-release > version of 1.19 out, this code block would never be executed, meaning it > would never be tested; it's better to be in the habit of using > EFL_VERSION_$MAJ_$MIN defines in applications for this reason. or if you look at the code instead as "this is the state right now and since efl is in release mode, pretending to be 1.19 then it's fine" and that the code is intended in FUTURE to work on FUTURE releases of efl as intended WHEN that future release of e comes out... so it's correct given that code in git is working towards the next release... :) at worst if you are on an older efl (efl from git) then you dont get this feature in your build which doesnt break your build... you are of course not recent enough to guarantee the feature is there in your efl... :) > On Fri, Feb 17, 2017 at 8:56 PM Carsten Haitzler <ras...@rasterman.com> > wrote: > > > On Sat, 18 Feb 2017 01:20:39 +0000 Mike Blumenkrantz > > <michael.blumenkra...@gmail.com> said: > > > > > This should probably be #ifdef EFL_VERSION_1_19 I think > > > > why? that #if check is right for checking if efl is 1.19 or newer... > > > > > On Fri, Feb 17, 2017 at 7:22 PM Christopher Michael < > > devilho...@comcast.net> > > > wrote: > > > > > > > devilhorns pushed a commit to branch master. > > > > > > > > > > > > > > http://git.enlightenment.org/core/enlightenment.git/commit/?id=4339f9f783bd507f2cf82f41643d3b31e523a02d > > > > > > > > commit 4339f9f783bd507f2cf82f41643d3b31e523a02d > > > > Author: Chris Michael <cp.mich...@samsung.com> > > > > Date: Fri Feb 17 19:21:17 2017 -0500 > > > > > > > > bump efl minor version check for ecore_drm2 API function usage > > > > > > > > Signed-off-by: Chris Michael <cp.mich...@samsung.com> > > > > --- > > > > src/modules/wl_drm/e_mod_main.c | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/src/modules/wl_drm/e_mod_main.c > > > > b/src/modules/wl_drm/e_mod_main.c > > > > index be44fef..e943a75 100644 > > > > --- a/src/modules/wl_drm/e_mod_main.c > > > > +++ b/src/modules/wl_drm/e_mod_main.c > > > > @@ -451,7 +451,7 @@ _drm2_randr_create(void) > > > > s->info.can_rot_180 = EINA_FALSE; > > > > s->info.can_rot_270 = EINA_FALSE; > > > > > > > > -# if (EFL_VERSION_MAJOR > 1) || (EFL_VERSION_MINOR >= 18) > > > > +# if (EFL_VERSION_MAJOR > 1) || (EFL_VERSION_MINOR >= 19) > > > > int rotations; > > > > > > > > rotations = > > > > @@ -623,7 +623,7 @@ _drm2_randr_apply(void) > > > > > > > > /* TODO: cannot support rotations until we support planes > > > > * and we cannot support planes until Atomic support is in */ > > > > -# if (EFL_VERSION_MAJOR > 1) || (EFL_VERSION_MINOR >= 18) > > > > +# if (EFL_VERSION_MAJOR > 1) || (EFL_VERSION_MINOR >= 19) > > > > int orient = 0; > > > > > > > > if (s->config.rotation == 0) > > > > > > > > -- > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------------ > > > Check out the vibrant tech community on one of the world's most > > > engaging tech sites, SlashDot.org! http://sdm.link/slashdot > > > _______________________________________________ > > > enlightenment-devel mailing list > > > enlightenment-devel@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > > > > > > > -- > > ------------- Codito, ergo sum - "I code, therefore I am" -------------- > > The Rasterman (Carsten Haitzler) ras...@rasterman.com > > > > -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) ras...@rasterman.com ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
