cedric pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=7c368923a1c257f843097bc8660377f7185fb7ae
commit 7c368923a1c257f843097bc8660377f7185fb7ae
Author: Prasoon Singh <prasoon...@samsung.com>
Date: Mon May 8 15:15:17 2017 -0700
elm_theme: check whether object is valid before calling edje_object_mmap_set
Summary:
In Issue scenario when _elm_theme_set was called,object was already deleted
by app causing
unnecessary addition of the style in style_not_found list.
Check for object validity, if object is NULL return theme apply failed.
Test Plan: Make object pointer NULL before _elm_theme_set is called.
Reviewers: cedric, shilpasingh
Subscribers: rajeshps, govi, cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4840
Signed-off-by: Cedric BAIL <ced...@osg.samsung.com>
---
src/lib/elementary/elm_theme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/lib/elementary/elm_theme.c b/src/lib/elementary/elm_theme.c
index 75f241f..a2ee5d6 100644
--- a/src/lib/elementary/elm_theme.c
+++ b/src/lib/elementary/elm_theme.c
@@ -301,7 +301,7 @@ _elm_theme_set(Elm_Theme *th, Evas_Object *o, const char
*clas, const char *grou
Eina_File *file;
char buf2[1024];
- if ((!clas) || (!group) || (!style)) return EINA_FALSE;
+ if ((!clas) || (!group) || (!style) || !o) return ELM_THEME_APPLY_FAILED;
if (!th) th = &(theme_default);
snprintf(buf2, sizeof(buf2), "elm/%s/%s/%s", clas, group, style);
if (!eina_hash_find(th->cache_style_load_failed, buf2))
--
