On Fri, 26 May 2017 03:20:28 -0400 "William L. Thomson Jr." <[email protected]> said:
> On Fri, 26 May 2017 13:42:54 +0900 > Carsten Haitzler (The Rasterman) <[email protected]> wrote: > > > in NOT having the env var set, it is odd. the fact it actively > > removes it AND doesnt go replace it later after removal is odd. > > They say why > > /* Remove the DISPLAY variable so that a pinentry does not > default to a specific display. There is still a default > display when gpg-agent was started using --display or a > client requested this using an OPTION command. Note, that we > don't do this when running in reverse daemon mode (i.e. when > exec the program given as arguments). */ yes. i read that. it's still provided to pinetry with --display ... why not provide it AS AN ENV VAR so pinentry doesn't need special "connect to this specific named display"? it'd be less code in pinentry binaries for a single putenv() in gpg-agent INSTEAD of the code adding --display to the cmdline. it's less code overall. > In one case it seems optional, but usage below previous comment is not. > > if (!opt.keep_display) > gnupg_unsetenv ("DISPLAY"); > > -- > William L. Thomson Jr. -- ------------- Codito, ergo sum - "I code, therefore I am" -------------- The Rasterman (Carsten Haitzler) [email protected] ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
