I bumped the version to 0.9.10 as other test suites require at least that version. I also removed this specific _nonnull macro (to require 0.9.10 and not 0.11.0).
On 29 May 2017 at 23:15, Amitesh Singh <[email protected]> wrote: > On Mon, May 29, 2017 at 9:09 PM, Stefan Schmidt <[email protected]> > wrote: > > > Hello. > > > > On 05/24/2017 06:00 AM, Jean-Philippe ANDRÉ wrote: > > > >> jpeg pushed a commit to branch master. > >> > >> http://git.enlightenment.org/core/efl.git/commit/?id=9d48350 > >> ae40eaa1ea6247c402dee06bb31553484 > >> > >> commit 9d48350ae40eaa1ea6247c402dee06bb31553484 > >> Author: Jean-Philippe Andre <[email protected]> > >> Date: Tue May 23 16:29:16 2017 +0900 > >> > >> edje: Implement EO API for message_send > >> Since this uses generic_value (aka Eina_Value), there is an > >> implicit type detection and conversion. I did not attempt to > >> cover all types (namely string+int and string+float and even > >> less sets of those) as I believe they aren't really used. Or > >> they most likely could be replaced by multiple messages rather > >> than a single message. > >> Note: should we pass ptr(generic_value) instead of > >> generic_value? > >> The API looks a little odd in C when passing by value. > >> @feature > >> > > / > > > >> --- a/src/tests/edje/edje_test_edje.c > >> +++ b/src/tests/edje/edje_test_edje.c > >> @@ -725,6 +725,148 @@ START_TEST(edje_test_combine_keywords) > >> } > >> END_TEST > >> +static void > >> +_message_signal_reply_cb(void *data, Evas_Object *obj EINA_UNUSED, > >> + const char *emission, const char *source) > >> +{ > >> + int *id = data; > >> + > >> + fprintf(stderr, "source %s emit %s id %d\n", source, emission, *id); > >> + fflush(stderr); > >> + ck_assert_str_eq(source, "edc"); > >> + ck_assert_ptr_nonnull(emission); > >> > > > > tests/edje/tests_edje_edje_suite-edje_test_edje.o: In function > > `_message_signal_reply_cb': > > /home/stefan/EFL/efl/src/tests/edje/edje_test_edje.c:737: undefined > > reference to `ck_assert_ptr_nonnull' > > > > This symbol is not available in check version 0.10 I have installed on > the > > latest Fedora release. Do you know with which version it got introduced? > > > > > 0.11.0 version has this function defined. > > /** > * Check if a pointer is not equal to NULL. > * > * If X == NULL, the test fails. > * > * @param X pointer to compare against NULL > * > * @note If the check fails, the remaining of the test is aborted > * > * @since 0.11.0 > */ > #define ck_assert_ptr_nonnull(X) _ck_assert_ptr_null(X, !=) > > ------ /usr/include/check.h ----- > > We need to either bump our dep for check to this version or we need to > > change this line. I prefer for the later until more distros have picked > up > > that release. > > > > regards > > Stefan Schmidt > > > > ------------------------------------------------------------ > > ------------------ > > Check out the vibrant tech community on one of the world's most > > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > _______________________________________________ > > enlightenment-devel mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > > > ------------------------------------------------------------ > ------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > enlightenment-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel > -- Jean-Philippe André ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ enlightenment-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
