jpeg pushed a commit to branch master. http://git.enlightenment.org/core/efl.git/commit/?id=d6652c1138a3edb28c5796ca9850047a69fc12cf
commit d6652c1138a3edb28c5796ca9850047a69fc12cf Author: JinYong Park <[email protected]> Date: Fri Jul 7 14:11:55 2017 +0900 popup: fix wrong signal emit when remove all button Summary: In visuals_set function, check action_area is NULL, and signal emit action_area,visible/hidden So, before call visuals_set, action_area should be deleted. Test Plan: Actually, action area has not min size, so it couldn't be observed. Reviewers: herb, singh.amitesh, jpeg, cedric, conr2d Reviewed By: jpeg Differential Revision: https://phab.enlightenment.org/D5007 --- src/lib/elementary/elc_popup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/elementary/elc_popup.c b/src/lib/elementary/elc_popup.c index ccb63c74a6..1cab8b7770 100644 --- a/src/lib/elementary/elc_popup.c +++ b/src/lib/elementary/elc_popup.c @@ -637,8 +637,8 @@ _button_remove(Evas_Object *obj, if (!sd->last_button_number) { - _visuals_set(obj); ELM_SAFE_FREE(sd->action_area, evas_object_del); + _visuals_set(obj); } else { --
