raster pushed a commit to branch master.

http://git.enlightenment.org/core/efl.git/commit/?id=08a69d228487a2356df3919a68fc749c2a696258

commit 08a69d228487a2356df3919a68fc749c2a696258
Author: Carsten Haitzler (Rasterman) <[email protected]>
Date:   Sat Jul 29 10:40:33 2017 +0900

    eeze_disk - remove redundant if check already done
    
    removes redundant fi check. not a bug but analysers dont like it and
    it is redundant
    
    found by PVS studio
---
 src/lib/eeze/eeze_disk.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/lib/eeze/eeze_disk.c b/src/lib/eeze/eeze_disk.c
index d1c77b44ba..60c4fa74b7 100644
--- a/src/lib/eeze/eeze_disk.c
+++ b/src/lib/eeze/eeze_disk.c
@@ -296,11 +296,11 @@ eeze_disk_scan(Eeze_Disk *disk)
    if (!disk->cache.vendor)
      disk->cache.vendor = udev_device_get_property_value(disk->device, 
"ID_VENDOR");
    if (!disk->cache.vendor)
-     if (!disk->cache.vendor) disk->cache.vendor = 
udev_device_get_sysattr_value(disk->device, "vendor");
+     disk->cache.vendor = udev_device_get_sysattr_value(disk->device, 
"vendor");
    if (!disk->cache.model)
      disk->cache.model = udev_device_get_property_value(disk->device, 
"ID_MODEL");
    if (!disk->cache.model)
-     if (!disk->cache.model) disk->cache.model = 
udev_device_get_sysattr_value(disk->device, "model");
+     disk->cache.model = udev_device_get_sysattr_value(disk->device, "model");
    if (!disk->cache.serial)
      disk->cache.serial = udev_device_get_property_value(disk->device, 
"ID_SERIAL_SHORT");
    if (!disk->cache.uuid)

-- 


Reply via email to